[FIXED] Fix subject tree intersection to match literals when combined with partial wildcards#7349
Merged
neilalexander merged 2 commits intomainfrom Sep 24, 2025
Merged
Conversation
… with partial wildcards Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
approved these changes
Sep 24, 2025
Member
neilalexander
left a comment
neilalexander
left a comment
There was a problem hiding this comment.
Partially marking my own homework, but LGTM!
sciascid
approved these changes
Sep 24, 2025
Contributor
sciascid
left a comment
sciascid
left a comment
There was a problem hiding this comment.
LGTM
Consider referencing the fixed issue directly in the commit message.
Member
Author
The merge commit contains the PR description, and the fixed issue mention as a result also: |
neilalexander
added a commit
that referenced
this pull request
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #6827, but when combining filter subjects of
stream.Aandstream.*.A.Resolves #7336
Signed-off-by: Maurice van Veen github@mauricevanveen.com