Skip to content

[IMPROVED] Fix small typos for leafnode.go#7337

Merged
neilalexander merged 1 commit intonats-io:mainfrom
yoonseo-han:yoonseo-han/fix-typo
Sep 22, 2025
Merged

[IMPROVED] Fix small typos for leafnode.go#7337
neilalexander merged 1 commit intonats-io:mainfrom
yoonseo-han:yoonseo-han/fix-typo

Conversation

@yoonseo-han
Copy link
Copy Markdown
Contributor

@yoonseo-han yoonseo-han commented Sep 22, 2025

Some typo fixes in comments for leafnode.go

Signed-off-by: Yoonseo Han yooncer00@gmail.com
(github id: yoonseo-han)

@yoonseo-han yoonseo-han requested a review from a team as a code owner September 22, 2025 05:33
@yoonseo-han yoonseo-han changed the title Fix small typos for leafnode.go [IMPROVED] Fix small typos for leafnode.go Sep 22, 2025
Copy link
Copy Markdown
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoonseo-han
Copy link
Copy Markdown
Contributor Author

LGTM

TYSM for the quick check.

The test errors that I am receiving seem irrelevant of the changes that I made. Mind if I ask for a rerun?

Sorry for the inconvenience and thanks

@neilalexander
Copy link
Copy Markdown
Member

Please squash down into one commit with the sign-off, and then we'll make sure that CI is green (there are a few flakes that need kicking but we can do that). Thanks!

- Corrected minor typos in leafnode.go
- Included empty commit to trigger CI rerun

Signed-off-by: Yoonseo Han <yooncer00@gmail.com>
@yoonseo-han
Copy link
Copy Markdown
Contributor Author

yoonseo-han commented Sep 22, 2025

Please squash down into one commit with the sign-off, and then we'll make sure that CI is green (there are a few flakes that need kicking but we can do that). Thanks!

Just did it for the most recent workflow!

Thanks for the advice.

@neilalexander neilalexander merged commit 6185032 into nats-io:main Sep 22, 2025
1 check passed
neilalexander added a commit that referenced this pull request Sep 29, 2025
Includes the following:

- #7290
- #7295
- #7291
- #7287
- #7299
- #7300
- #7297
- #7303
- #7304
- #7305
- #7309
- #7307
- #7320
- #7337
- #7344
- #7345
- #7348
- #7349
- #7350
- #7357
- #7356
- #7358
- #7367
- #7293

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Sep 29, 2025
Includes the following:

- #7337
- #7342
- #7344
- #7345
- #7347
- #7346
- #7348
- #7349
- #7350
- #7357
- #7356
- #7358
- #7359
- #7366
- #7367
- #7293
- #7368

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants