Correct and simplify stream assignment check#7290
Merged
neilalexander merged 1 commit intomainfrom Sep 10, 2025
Merged
Conversation
Remove misleading comment for the loop at the end of isStreamAssigned: "Check if we are the leader of this raftGroup [...]". This code is checking for membership, not leadership of the group. Instead of fixing the comment, replace the whole loop with a call to isMember. Same for isConsumerAssigned. Signed-off-by: Daniele Sciascia <daniele@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove misleading comment for the loop at the end of isStreamAssigned: "Check if we are the leader of this raftGroup [...]". This code is checking for membership, not leadership of the group.
Instead of fixing the comment, replace the whole loop with a call to isMember.
Same for isConsumerAssigned.
Signed-off-by: Daniele Sciascia daniele@nats.io