Patch 2 #4
Closed
Patch 2 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: facebook#51131 changelog: [internal] add test for View.accessibilityRole. Reviewed By: rubennorte Differential Revision: D74247897 fbshipit-source-id: 9246e690fe15fc659b134cf2484a5ac64ff321d7
Summary: Pull Request resolved: facebook#51122 Update Metro to 0.82.2 => 0.82.3, containing important bug fixes for `package.json#exports` support. Changelog: [General][Changed] Metro to ^0.82.3 Reviewed By: huntie Differential Revision: D74181990 fbshipit-source-id: 8320a0cf4aa671d9e7f2976c36d260934807a179
…typescript (facebook#51068) Summary: Added decalaration for pressRetentionOffset prop to be recognised by typescript ## Changelog: Added decalaration for pressRetentionOffset prop to be recognised by typescript in Text.d.ts <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [General] [Added] - Add pressRetentionOffset prop to be recognised by typescript in Text.d.ts Pull Request resolved: facebook#51068 Test Plan: Before fix https://github.com/user-attachments/assets/476364c4-6602-4916-84f2-1ede56bce285 After fix https://github.com/user-attachments/assets/e5f720d9-cd7d-4cf0-8499-ebe9f83eb17b Tested here: Related PR: (microsoft/react-native-windows#14596) Reviewed By: yungsters Differential Revision: D74208617 Pulled By: philIip fbshipit-source-id: 625996bec64058e4e4cdbe108ed53a62426d1222
…acebook#51089) Summary: Pull Request resolved: facebook#51089 Currently, `IntersectionObserver#observe` retains a reference to the `ShadowNode` of the view that is supplied as an argument, which is used to compute intersection whenever a shadow tree is committed. However, the `shadowNode` includes all of child nodes and state at the time that `IntersectionObserver#observe` is called. This means that an active `IntersectionObserverEntry` will retain references to memory that would otherwise be deallocated (e.g. if children of the observed view are unmounted after `IntersectionObserver#observe` is called). This diff refactors `IntersectionObserver` to instead retain a reference to the `ShadowNodeFamily`, which does not retain references to child nodes and still eanbles `IntersectionObserver` to compute intersections. Changelog: [General][Changed] - Fixed `IntersectionObserver#observe` to avoid retaining memory for unmounted child nodes of observed views. Reviewed By: RSNara Differential Revision: D74130479 fbshipit-source-id: 6b581f73f06b93e6463d5004c181c39aae13896a
…ed on soft errors (facebook#51141) Summary: Pull Request resolved: facebook#51141 This diff introduces ReactSoftExceptionLogger.CategoryMode to limit categories used on soft errors, the limiation will only create a lint warning but won't create a compilation error. changelog: [internal] internal Reviewed By: javache Differential Revision: D74263367 fbshipit-source-id: 56fb2ef0ad3d24810172af300e43ecc1f479464f
…1120) Summary: Pull Request resolved: facebook#51120 Changelog: [Internal] Reviewed By: huntie Differential Revision: D74242678 fbshipit-source-id: b39b56bb3a34633bec55f07c8bf081fb70b62249
Summary: Static code analysis shows that there are a lot of unresolved KDoc references. This is just another round addressing several of them. ## Changelog: [INTERNAL] - Fix unresolved KDoc references Pull Request resolved: facebook#51142 Test Plan: Verify that the comments link the classes correctly using Android Studio. Reviewed By: rshest Differential Revision: D74305933 Pulled By: javache fbshipit-source-id: f512a33fa5da46fb828bb76bd95d9502261ea08a
Summary: Pull Request resolved: facebook#51126 NOTE: Resubmission of D73922341, fixing a dependency cycle (T223145455). (Sparsely) wires up reporting of Network events to the Web Performance subsystem. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D74245441 fbshipit-source-id: ce8f47dfb3f5cd415f51287d7fcc6a048336018e
…for Fantom test specific methods (facebook#51133) Summary: Pull Request resolved: facebook#51133 Changelog: [internal] Having a single native module with all the test-specific functionality that we need in native in Fantom is just more convenient. Reviewed By: rshest, huntie Differential Revision: D73997209 fbshipit-source-id: 5d3aa69a2c799166a1351fbff3e80e4396cec9c6
Summary: Pull Request resolved: facebook#51128 Changelog: [internal] Just a minor refactor of a method in `MutationObserver` which was doing some redundant work that could be avoided. Reviewed By: javache Differential Revision: D74247437 fbshipit-source-id: 510d26f2a315582df9cddc215bf516d3d4ebd341
…revent leaks (facebook#51149) Summary: Pull Request resolved: facebook#51149 Changelog: [internal] This replaces the use of `ShadowNode` with `ShadowNodeFamily` in the `MutationObserver` logic to prevent retaining stale subtrees of the nodes being observed. It refactors some existing logic so we don't need to keep track of the shadow nodes in JS. It was only used to be able to find the node for a target after unmounted, so we could "unobserve" it, but `MutationObserver` doesn't support unobserving individual targets anyway, so we removed that use case and implemented a more general `unobserveAll` method that doesn't require the shadow nodes in the first place. Reviewed By: javache Differential Revision: D74240834 fbshipit-source-id: 6d4c43a561780962874c76615fb53369c0c68cf7
Summary: Pull Request resolved: facebook#51127 Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D74246823 fbshipit-source-id: af3978c120853d4ef1150fffb38c71c74728f907
…ebook#51151) Summary: Pull Request resolved: facebook#51151 changelog: [General][Deprecated] - deprecate type aliases ShadowNode::Unshared and ShadowNode::Weak in favour of std::shared_ptr<ShadowNode> and std::weak_ptr<ShadowNode> migrate away from using these type aliases to avoid confusion. It is unclear from ShadowNode::Unshared what it means. This can be avoided by using std::shared_ptr<ShadowNode> directly. The same applies to ShadowNode::Weak. Reviewed By: rubennorte Differential Revision: D74245228 fbshipit-source-id: f22a18e87f170e46f5079e0ee7678700a3f5f623
Summary: This class can be internalized as part of the initiative to reduce the public API surface. I've checked there are [no relevant OSS usages](https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+NOT+user%3Acortinico+NOT+repo%3AMaxdev18%2Fpowersync_app+NOT+repo%3Acarter-0%2Finstagram-decompiled+NOT+repo%3Am0mosenpai%2Finstadamn+NOT+repo%3AA-Star100%2FA-Star100-AUG2-2024+NOT+repo%3Alclnrd%2Fdetox-scrollview-reproductible+NOT+repo%3ADionisisChytiris%2FWorldWiseTrivia_Main+NOT+repo%3Apast3l%2Fhi2+NOT+repo%3AoneDotpy%2FCaribouQuest+NOT+repo%3Abejayoharen%2Fdailytodo+NOT+repo%3Amolangning%2Freversing-discord+NOT+repo%3AScottPrzy%2Freact-native+NOT+repo%3Agabrieldonadel%2Freact-native-visionos+NOT+repo%3AGabriel2308%2FTestes-Soft+NOT+repo%3Adawnzs03%2FflakyBuild+NOT+repo%3Acga2351%2Fcode+NOT+repo%3Astreeg%2Ftcc+NOT+repo%3Asoftware-mansion-labs%2Freact-native-swiftui+NOT+repo%3Apkcsecurity%2Fdecompiled-lightbulb+com.facebook.react.common.DebugServerException). ## Changelog: [INTERNAL] - Make com.facebook.react.common.DebugServerException internal Pull Request resolved: facebook#51140 Test Plan: ```bash yarn test-android yarn android ``` Reviewed By: javache Differential Revision: D74309486 Pulled By: rshest fbshipit-source-id: 092ffb350d9093deb6b12ad639dd7453027c4c06
Summary: This class can be internalized as part of the initiative to reduce the public API surface. I've checked there are [no relevant OSS usages](https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+NOT+user%3Acortinico+NOT+repo%3AMaxdev18%2Fpowersync_app+NOT+repo%3Acarter-0%2Finstagram-decompiled+NOT+repo%3Am0mosenpai%2Finstadamn+NOT+repo%3AA-Star100%2FA-Star100-AUG2-2024+NOT+repo%3Alclnrd%2Fdetox-scrollview-reproductible+NOT+repo%3ADionisisChytiris%2FWorldWiseTrivia_Main+NOT+repo%3Apast3l%2Fhi2+NOT+repo%3AoneDotpy%2FCaribouQuest+NOT+repo%3Abejayoharen%2Fdailytodo+NOT+repo%3Amolangning%2Freversing-discord+NOT+repo%3AScottPrzy%2Freact-native+NOT+repo%3Agabrieldonadel%2Freact-native-visionos+NOT+repo%3AGabriel2308%2FTestes-Soft+NOT+repo%3Adawnzs03%2FflakyBuild+NOT+repo%3Acga2351%2Fcode+NOT+repo%3Astreeg%2Ftcc+NOT+repo%3Asoftware-mansion-labs%2Freact-native-swiftui+NOT+repo%3Apkcsecurity%2Fdecompiled-lightbulb+com.facebook.react.bridge.queue.ReactQueueConfigurationImpl). ## Changelog: [INTERNAL] - Make com.facebook.react.bridge.queue.ReactQueueConfigurationImpl internal Pull Request resolved: facebook#51143 Test Plan: ```bash yarn test-android yarn android ``` Reviewed By: rshest, cortinico Differential Revision: D74309556 Pulled By: javache fbshipit-source-id: 1c5eaa0e975bd2db5d451c5e21f14cfa3856e4c3
Summary: When testing the release by running the `test-e2e-local` for RNTester on iOS, the script sometimes fails because it expect to have codegen properly built before running the app. This fix makes sure we build the codegen package. ## Changelog: [Internal] - Fix building the codegen Pull Request resolved: facebook#51130 Test Plan: Tested locally Reviewed By: fabriziocucci Differential Revision: D74248031 Pulled By: cipolleschi fbshipit-source-id: 319f3332c616f7118b673fb7acb63c2e15946b2c
Summary: Pull Request resolved: facebook#51159 This change fixes a syntax error in the GH Action that generates the draft PR. ## Changelog: [Internal] - Fix draft release generation Reviewed By: fabriziocucci, cortinico Differential Revision: D74322577 fbshipit-source-id: 0fcb03403ea35f7c64217bce5f1cbf93e7d5bd9a
…ok#51157) Summary: Pull Request resolved: facebook#51157 test-js jobs are failing because the codegen snapshot tests generates a Podspecs withan hardcoded version that does not matches the version we are about to release. This fix updates the script that set the RN version to make sure it also updates the Codegen snapshots. This is a porting to `main` of [this PR](facebook#51156). ## Changelog: [Internal] - Fix set-rn-version to account for codegen snapshot test files Reviewed By: fabriziocucci, cortinico Differential Revision: D74321590 fbshipit-source-id: 6837e60a0a2834030680f7ec0c7584bf2622f33e
…cebook#51161) Summary: Pull Request resolved: facebook#51161 This unbreaks the CI after D74245228 Changelog: [Internal] [Changed] - Reviewed By: javache Differential Revision: D74324800 fbshipit-source-id: b89147f4f57b5d94fd8ae1549ef18ef2deb97c5b
Summary: Static code analysis detected several missing `ReplaceWith` on deprecated methods. This diff addresses some of them by adding the most accurate suggestions based on the implementations. ## Changelog: [INTERNAL] - Add missing ReplaceWith on deprecations Pull Request resolved: facebook#51144 Test Plan: ```sh yarn android yarn test-android ``` Reviewed By: fabriziocucci Differential Revision: D74327121 Pulled By: javache fbshipit-source-id: 5b338531210bef104208d14cbd0e3320dc566b8e
Summary: Pull Request resolved: facebook#51164 As per title. Changelog: [Internal] Reviewed By: javache Differential Revision: D74326679 fbshipit-source-id: ecd15fda9ea8686b65171c462e7e82dc9609377b
Summary: Pull Request resolved: facebook#51155 changelog: [internal] we have experienced breakages where we stopped propagating accessibility prop to the mounting layer. These tests should catch it. Reviewed By: fabriziocucci Differential Revision: D74317767 fbshipit-source-id: 72c6d8c788afe3a9d4d41f7cfc0aa37605b20b6a
…acebook#51138) Summary: Pull Request resolved: facebook#51138 The co-opting logic failed to account fo the case where the entire text view as a link and therefore turns off ax. In this case I think it makes sense to re-focus that element again so the user can interact with the link. Changelog: [Internal] Reviewed By: jorge-cab Differential Revision: D74262675 fbshipit-source-id: c8d11cdff76cd92170581d167d5a8df64d0dd101
Summary: Switches to use the version imported through diff train for `eslint-plugin-react-hooks`. This should allow us to finally use component syntax in RN. bypass-github-export-checks Changelog: [internal] Reviewed By: yungsters Differential Revision: D74203162 fbshipit-source-id: d9ea17e5c6533e8df0889404a7f7798f6f5061c0
Summary: Pull Request resolved: facebook#51177 Introduce DefaultNewArchitectureEntryPoint.loadWithFeatureFlags() to allow custom feature flags while using DefaultNewArchitectureEntryPoint Reviewed By: arushikesarwani94 Differential Revision: D74228467 fbshipit-source-id: ec3fe7edd31cc9713498b316d6306eaa3686398b
Summary: Chronos Job Instance ID: 1125907957818733 Sandcastle Job Instance ID: 31525199229818080 Processed xml files: android_res/com/facebook/common/util/res/values/strings.xml android_res/com/oculus/auth/authenticator/meta/res/values/strings.xml android_res/com/oculus/horizon/common/res/values/strings.xml android_res/com/oculus/horizon/platformplugin/res/values/strings.xml android_res/com/oculus/horizon/try_before_you_buy/res/values/strings.xml android_res/com/oculus/os/q4b/mma/res/values/strings.xml android_res/com/oculus/horizon/mediaupload/res/values/strings.xml android_res/com/oculus/horizon/linkedaccounts/res/values/strings.xml android_res/com/oculus/auth/authenticator/work/res/values/strings.xml android_res/com/oculus/auth/authenticator/oculus/res/values/strings.xml android_res/com/oculus/auth/authenticator/instagramsso/res/values/strings.xml android_res/com/oculus/auth/authenticator/horizonworldsplatform/res/values/strings.xml android_res/com/oculus/auth/authenticator/facebooksso/res/values/strings.xml android_res/com/oculus/auth/authenticator/facebook/res/values/strings.xml android_res/com/oculus/demoapp/res/values/strings.xml android_res/com/facebook/wearable/common/comms/notification/res/values/strings.xml android_res/com/facebook/wearable/apps/igdirect/res/values/strings.xml android_res/com/facebook/wearable/common/wds/theme/res/values/strings.xml ../xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/res/views/uimanager/values/strings.xml ../xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/res/systeminfo/values/strings.xml android_res/rendercore/res/values/strings.xml ../xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/res/devsupport/values/strings.xml android_res/com/facebook/content/res/values/strings.xml android_res/com/facebook/common/i18n/res/values/strings.xml android_res/com/facebook/common/timeformat/res/values/strings.xml libraries/foa/ui/cds/widgets-litho/brandasset/res/values/strings.xml android_res/com/meta/icon/res/values/strings.xml android_res/com/facebook/resources/res/values/strings.xml android_res/com/facebook/common/strings/external/res/values/strings.xml android_res/com/facebook/common/strings/res/values/strings.xml android_res/com/oculus/twilight/app/res/values/strings.xml android_res/com/facebook/fbui/widget/pagerindicator/res/values/strings.xml android_res/com/facebook/fbui/widget/contentview/res/values/strings.xml android_res/com/facebook/stella/res/values/strings.xml android_res/com/facebook/wearable/companion/settings/keys/res/values/strings.xml android_res/com/bloks/foa/cds/bottomsheet/strings/res/values/strings.xml android_res/com/facebook/reportaproblem/res/values/strings.xml android_res/com/oculus/twilight/reportaproblem/res/values/strings.xml android_res/com/facebook/widget/res/values/strings.xml android_res/com/facebook/config/appspecific/res/values/strings.xml android_res/com/facebook/fbavatar/res/values/strings.xml android_res/com/facebook/messaging/ui/stickerstore/res/values/strings.xml android_res/com/facebook/stickers/res/values/strings.xml android_res/com/facebook/messaging/shared/res/values/strings.xml android_res/com/facebook/caspian/res/values/strings.xml android_res/com/facebook/timeline/widget/actionbar/res/values/strings.xml android_res/com/facebook/showpages/res/values/strings.xml android_res/com/facebook/nux/res/values/strings.xml android_res/com/facebook/facecast/common/badge/res/values/strings.xml android_res/com/facebook/nativetemplates/res/values/strings.xml android_res/com/facebook/iorg/common/upsell/res/values/strings.xml android_res/com/facebook/iorg/common/res/values/strings.xml android_res/com/facebook/zero/common/res/values/strings.xml android_res/com/facebook/video/components/feed/res/values/strings.xml android_res/com/facebook/runtimepermissions/res/values/strings.xml android_res/com/facebook/dialtone/res/values/strings.xml android_res/com/oculus/twilight/gcm/messaging/res/values/strings.xml android_res/com/oculus/twilight/gcm/followrequest/res/values/strings.xml android_res/com/facebook/rtc/notification/res/values/strings.xml android_res/com/facebook/rp/platform/ui/common/res/values/strings.xml android_res/com/facebook/zero/messenger/semi/res/values/strings.xml android_res/com/facebook/zero/res/values/strings.xml android_res/com/facebook/widget/facepile/res/values/strings.xml android_res/com/facebook/tabbar/res/values/strings.xml android_res/com/facebook/ui/toolbar/res/values/strings.xml android_res/com/facebook/dialtone/messenger/res/values/strings.xml android_res/com/facebook/catalyst/shell/res/values/strings.xml android_res/com/facebook/rtc/runtimepermissions/manager/res/values/strings.xml android_res/com/facebook/rtc/connectionservice/res/values/strings.xml android_res/com/facebook/rtc/helpers/connectionservicecoordinator/res/values/strings.xml android_res/com/facebook/rp/platform/ui/callstatus/participantinfo/res/values/strings.xml android_res/com/facebook/rp/platform/ui/callstatus/res/values/strings.xml android_res/com/facebook/rp/platform/ui/incoming/res/values/strings.xml android_res/com/facebook/rp/platform/ui/participant/res/values/strings.xml android_res/com/facebook/rp/platform/ui/pip/res/values/strings.xml android_res/com/facebook/rp/platform/ui/header/res/values/strings.xml android_res/com/facebook/rp/platform/ui/callcontrols/audioselector/res/values/strings.xml android_res/com/facebook/rp/platform/ui/callcontrols/res/values/strings.xml android_res/com/facebook/rp/platform/ui/incall/res/values/strings.xml android_res/com/facebook/rp/platform/ui/ended/res/values/strings.xml android_res/com/facebook/payments/dcp/res/values/strings.xml libraries/smartcapture/common/common-ui/res/values/strings.xml android_res/com/bloks/common/components/autogenmediagallery/res/values/strings.xml android_res/com/facebook/ui/mainview/res/values/strings.xml android_res/com/facebook/audience/stories/storysurface/activity/main/res/values/strings.xml android_res/com/facebook/horizon/res/values/strings.xml android_res/com/meta/fxmetalogin/res/values/strings.xml android_res/com/instagram/ui/common/res/values/strings.xml android_res/com/instagram/actionbar/res/values/strings.xml android_res/com/instagram/tabs/res/values/strings.xml android_res/com/instagram/avatar/res/values/strings.xml android_res/com/instagram/icons/igax/res/values/strings.xml android_res/com/instagram/debug/res/values/strings.xml android_res/com/facebookpay/widget/res/values/strings.xml android_res/com/facebookpay/ecpexception/res/values/strings.xml android_res/com/facebookpay/expresscheckout/res/values/strings.xml android_res/com/fbpay/auth/res/values/strings.xml android_res/com/oculus/twilight/hsrmobile/res/values/strings.xml android_res/com/oculus/twilight/calling/res/values/strings.xml ../xplat/messengervr/msys/feature_aggregation/src/i18n/res/values/strings.xml allow-large-files ignore-conflict-markers opt-out-review drop-conflicts Differential Revision: D74381578 fbshipit-source-id: 3e17ebecf9bd5a6822bf98c9d195885320705655
Summary: Enables `DEFINES_MODULE` in `React-jsc.podspec` After upgrading app to RN `0.79`, when installing pods with JSC enabled there is an error being thrown that `The following Swift pods cannot yet be integrated as static libraries` `The Swift pod 'RNFlashList' depends upon 'React-jsc', which does not define modules. ...` when installing packages that use Swift ## Changelog: [IOS] [CHANGED] - enable `DEFINES_MODULE` in `React-jsc.podspec` Pull Request resolved: facebook#51160 Test Plan: RNTester runs and builds correctly Reviewed By: huntie Differential Revision: D74325357 Pulled By: cipolleschi fbshipit-source-id: b994b7e678633440d5e362ae6965b2d5188d34f1
Summary: Add Changelog for 0.80.0-rc.0 ## Changelog: [Internal] - Add Changelog for 0.80.0-rc.0 Pull Request resolved: facebook#51152 Test Plan: N/A Reviewed By: rshest Differential Revision: D74333203 Pulled By: hezi fbshipit-source-id: 052147550ecbe47f9e75dba6ebf6257a10a49f5b
Summary: Pull Request resolved: facebook#51162 We specify the java target version to 17 for ReactAndroid but not for hermes-engine. This is causing it to be the default (8) which will cause our build to fail on JDK 21. This fixes it. Changelog: [Internal] [Changed] - Reviewed By: alanleedev Differential Revision: D74325107 fbshipit-source-id: 39ba745be4fa754fb0b0408160202940a61fcd94
Summary: Follow up from facebook#51061 – Static code analysis detected several redundant constructs across the codebase. Most of the ones fixed here are marked as warnings/weak warnings, likely code smells post-migration from Java. Doing another small round to clean up some of them. ## Changelog: [INTERNAL] - Kotlin: Clean up redundant constructs Pull Request resolved: facebook#51170 Test Plan: ```sh yarn android yarn test-android ``` Reviewed By: rshest Differential Revision: D74381864 Pulled By: cortinico fbshipit-source-id: 25244cdf384875f7cc4e2d091c8b247710de5ecf
Summary: Pull Request resolved: facebook#51412 Prefers using this as a destructured import instead of as a member expression of `React`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74895839 fbshipit-source-id: 9ab9fc8bdee6d1764ad86fa2165da32cb266174e
Summary: Pull Request resolved: facebook#51408 Prefers using this as a destructured import instead of as a member expression of `React`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74895838 fbshipit-source-id: 2cc369e168a7ee10aa4374717f817636841c372c
Summary: Pull Request resolved: facebook#51411 Prefers using this as a destructured import instead of as a member expression of `React`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74895840 fbshipit-source-id: 0a3d78d2871c3334b6e1b570744962a4d0168a9e
Summary: Pull Request resolved: facebook#51410 Prefers using this as a destructured import instead of as a member expression of `React`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74895844 fbshipit-source-id: 67f334981a1effce051c89e3d4643232aa22b4e9
Summary: Pull Request resolved: facebook#51409 Prefers using this as a destructured import instead of as a member expression of `React`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74895837 fbshipit-source-id: b9d6082e4882d95f0d2aa1eed13b725edeb854cd
Summary: Pull Request resolved: facebook#51413 Prefers using this as a destructured import instead of as a member expression of `React`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74895841 fbshipit-source-id: c1d3af40134a3721c9a7b676ee1f2c4a18612e4d
…51402) Summary: Pull Request resolved: facebook#51402 changelog: [internal] the return value is unused. Let's remove it. Reviewed By: zeyap Differential Revision: D74884875 fbshipit-source-id: 83449ea298bdfbd7d083080aaa4d214bf246fcab
Summary: Pull Request resolved: facebook#51415 Adds the `format` annotation to all files that were missing them. Also, adds `noformat` to generated files, and removed it from files that no longer need them. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74901034 fbshipit-source-id: 7e0b85ca8ee2de41278f3aa23cb03e9c266d9c28
Summary: Pull Request resolved: facebook#51416 Deletes `oncall` annotations from the `facebook/react-native` repository. Changelog: [Internal] Reviewed By: javache Differential Revision: D74902524 fbshipit-source-id: 32a6a5b2ff27281792d572f151e2b094d9a79029
Summary: Pull Request resolved: facebook#51426 Fixes a bunch of ESLint warnings across the codebase. The only remaining warnings are from the `lint/no-commonjs-exports` rule. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74942686 fbshipit-source-id: 384de34c7297f7f7fcff1827c8b2e46714a5cda7
Summary: Pull Request resolved: facebook#51427 Migrates files to use ESM to mitigate the existing lint warning. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74942792 fbshipit-source-id: a9f5b3e73d4c89f3dd499053d9b575c2eb3b9842
) Summary: Pull Request resolved: facebook#51431 Migrates files to use ESM to mitigate the existing lint warning. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74942842 fbshipit-source-id: bc68b1a3422e97bafc23516e429877a6624f37a3
Summary: Pull Request resolved: facebook#51433 This `ErrorUtils` mock is dead code. There is no `ErrorUtils` module in React Native. (Maybe there was once upon a time...) Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74942884 fbshipit-source-id: 893458c4bc6f9ed29452579ce81915a52e6cd649
Summary: Pull Request resolved: facebook#51434 Migrates files to use ESM to mitigate the existing lint warning. I am suppressing `RelativeImageStub` to preserve compatibility with the dynamic asset exports generated by Metro (i.e. not ESM with `default` exports). Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74943031 fbshipit-source-id: ac4b2afd96fe5446acb4452395d7cb42bb5a6c17
Summary: Pull Request resolved: facebook#51437 Migrates files to use ESM to mitigate the existing lint warning. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74949792 fbshipit-source-id: d1372bb3a8615fe4544d67f04d26237b06515bad
) Summary: Pull Request resolved: facebook#51438 The `ReactNativePrivateInterface` module needs to continue using `module.exports` in order to lazily import dependencies. For now, we just suppress the `lint/no-commonjs-exports` lint rule. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74949839 fbshipit-source-id: 295853be7fb988b879b6fd0b15ef31dd6e47cf85
Summary: Pull Request resolved: facebook#51439 Migrates the `BackHandler` mock to use ESM to mitigate the existing lint warning. I'm actually not sure this is even used anywhere… and the unmocked `BackHandler` is already using ESM. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74949885 fbshipit-source-id: 7f37212db2125bb7afdbd342175e3beae6c7c14f
Summary: Pull Request resolved: facebook#51440 Migrates files to use ESM to mitigate the existing lint warning. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74949984 fbshipit-source-id: e89eb482835cb3a3d3b997dc766803dd307a6b99
…cebook#51441) Summary: Pull Request resolved: facebook#51441 Refactors `RNTesterPlatformTestEventRecorder` so that it does not use `useMemo` from an instance method. Instead, this diff changes the module to export a hook by the same name, `useRecorderTestEventHandlers`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74950333 fbshipit-source-id: 6cb222a6ec077abadbdc7008e822645aba3d07f6
Summary: Pull Request resolved: facebook#51393 In D74738548 we copied RCTFollyConvert to Follyconvert and we moved it to a separate file. The problem is that when we build react native, we now might have duplicated symbols, especially with prebuilds where the symbols are "flattened" together. To fix this, we can have the old file point to the new file in order not to break our suers and have a single symbol anyway. ## Changelog: [Internal] - Reviewed By: sammy-SC Differential Revision: D74883143 fbshipit-source-id: 98361307286cdc19c57b8f5c9f066aebea992896
Summary: Pull Request resolved: facebook#51435 Changelog: [Internal] Adding a technical documentation for the Runtime Shadow Node Referece Update (RSNRU) feature. Reviewed By: rshest Differential Revision: D74943809 fbshipit-source-id: cf5cc02adefa2635efb29e498747fc733711c2e4
Summary: Pull Request resolved: facebook#51447 Changelog: [Internal] Document how the `passChildrenWhenCloningPersistedNodes` feature works. Reviewed By: rshest Differential Revision: D74961913 fbshipit-source-id: 6f412de36acc233a6bdf3d59548035ad884264a8
Summary: Pull Request resolved: facebook#51446 See title Changelog: [Internal] Reviewed By: rshest Differential Revision: D74958927 fbshipit-source-id: 245397c6e9a89a40e5c1260fcd624e5f6b9f7c8d
Summary: Pull Request resolved: facebook#51451 This diff adds the `fantom_hermes_variant` pragma which can be set to: - `hermes` for the default Hermes runtime used by RN - `static_hermes` for the stable version of Static Hermes - `static_hermes_trunk` for the "trunk" version of Static Hermes Each variant will set up the correct build options for the runner and the correct compiler to use for the bundle. Changelog: [Internal] Reviewed By: rshest Differential Revision: D74959718 fbshipit-source-id: 5d30c8e15ab052eb5686f26632f08ab42b5e68c7
…ent (facebook#51420) Summary: Pull Request resolved: facebook#51420 The checked and unchecked state of the accessibility state property has to be serialized as `{ "checked": true }` and `{"checked": false}`. This diff updates the serialization of the `accessibilityState` prop for the prop diffing on the View component. This fixes the e2e test selectors for radio buttons. Changelog: [Internal] Reviewed By: rshest Differential Revision: D74910744 fbshipit-source-id: 212b78e29a007744ac9283c7ec9b96ce80fd5681
Summary: Pull Request resolved: facebook#51421 See title Changelog: [Internal] Reviewed By: rshest Differential Revision: D74915629 fbshipit-source-id: 0c24426c5e04ab3fc6ee85a4ca53e6095f0d3fce
Summary: Pull Request resolved: facebook#51422 See title Changelog: [Internal] Reviewed By: rshest Differential Revision: D74915630 fbshipit-source-id: e7a556229d04f835b80752259d01330d0f4fcd62
Summary: Pull Request resolved: facebook#51380 Changelog: [internal] Adding more examples of tests for core components with Fantom :) Reviewed By: lenaic Differential Revision: D74874581 fbshipit-source-id: 1285c4d222cb811b51155871c245b1bd5889b47a
currently the rejected promises are lost in void due to direct use of logbox with level warn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
Test Plan: