[RN][Release] Fix set-rn-version to account for codegen snapshot test files #51156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
changed the title
fabriziocucci
approved these changes
May 7, 2025
cipolleschi
force-pushed
the
cipolleschi/fix-set-rn-version
branch
2 times, most recently
from
4881cdb to
e4d21f2
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 7, 2025
Summary: test-js jobs are failing because the codegen snapshot tests generates a Podspecs withan hardcoded version that does not matches the version we are about to release. This fix updates the script that set the RN version to make sure it also updates the Codegen snapshots. This is a porting to `main` of [this PR](facebook#51156). ## Changelog: [Internal] - Fix set-rn-version to account for codegen snapshot test files Differential Revision: D74321590
cipolleschi
force-pushed
the
cipolleschi/fix-set-rn-version
branch
3 times, most recently
from
225f9e9 to
e9e90f8
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 7, 2025
…ok#51157) Summary: test-js jobs are failing because the codegen snapshot tests generates a Podspecs withan hardcoded version that does not matches the version we are about to release. This fix updates the script that set the RN version to make sure it also updates the Codegen snapshots. This is a porting to `main` of [this PR](facebook#51156). ## Changelog: [Internal] - Fix set-rn-version to account for codegen snapshot test files Reviewed By: fabriziocucci, cortinico Differential Revision: D74321590
cipolleschi
force-pushed
the
cipolleschi/fix-set-rn-version
branch
from
e9e90f8 to
91e7251
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
May 7, 2025
Summary: Pull Request resolved: #51157 test-js jobs are failing because the codegen snapshot tests generates a Podspecs withan hardcoded version that does not matches the version we are about to release. This fix updates the script that set the RN version to make sure it also updates the Codegen snapshots. This is a porting to `main` of [this PR](#51156). ## Changelog: [Internal] - Fix set-rn-version to account for codegen snapshot test files Reviewed By: fabriziocucci, cortinico Differential Revision: D74321590 fbshipit-source-id: 6837e60a0a2834030680f7ec0c7584bf2622f33e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
test-js jobs are failing because the codegen snapshot tests generates a Podspecs withan hardcoded version that does not matches the version we are about to release.
This fix updates the script that set the RN version to make sure it also updates the Codegen snapshots.
This change also fixes the currently broken snapshots.
Changelog:
[Internal] - Fix set-rn-version script to update codegen snapshots
Test Plan:
Tested locally by
And verifying that only the snapshot got updated.
Tested that the jest test were passing by running