Avoid duplicated symbols for FollyConvert.h functions #51393
Closed
+8
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74883143 |
cipolleschi
force-pushed
the
export-D74883143
branch
from
3e3ca55 to
2518d98
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 18, 2025
Summary: In D74738548 we copied RCTFollyConvert to Follyconvert and we moved it to a separate file. The problem is that when we build react native, we now might have duplicated symbols, especially with prebuilds where the symbols are "flattened" together. To fix this, we can have the old file point to the new file in order not to break our suers and have a single symbol anyway. ## Changelog: [Internal] - Reviewed By: sammy-SC Differential Revision: D74883143
Summary: Pull Request resolved: facebook#51393 In D74738548 we copied RCTFollyConvert to Follyconvert and we moved it to a separate file. The problem is that when we build react native, we now might have duplicated symbols, especially with prebuilds where the symbols are "flattened" together. To fix this, we can have the old file point to the new file in order not to break our suers and have a single symbol anyway. ## Changelog: [Internal] - Reviewed By: sammy-SC Differential Revision: D74883143
|
This pull request was exported from Phabricator. Differential Revision: D74883143 |
cipolleschi
force-pushed
the
export-D74883143
branch
from
2518d98 to
3e9dcce
Compare
|
This pull request has been merged in 2fa9c85. |
|
This pull request was successfully merged by @cipolleschi in 2fa9c85 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In D74738548 we copied RCTFollyConvert to Follyconvert and we moved it to a separate file.
The problem is that when we build react native, we now might have duplicated symbols, especially with prebuilds where the symbols are "flattened" together.
To fix this, we can have the old file point to the new file in order not to break our suers and have a single symbol anyway.
Changelog:
[Internal] -
Reviewed By: sammy-SC
Differential Revision: D74883143