Kotlin: Clean up redundant constructs #51061
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
What's the lint rule removing final from override and some classes? No strong opinion either way, but it does show up as an API delta/ |
@javache see this: https://www.jetbrains.com.cn/en-us/help/inspectopedia/RedundantModalityModifier.html, that one is the specific warning static code analysis detected for those. But I can put them back if we don't want to fix those or if it's causing issues internally. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 8, 2025
Summary: Follow up from #51061 – Static code analysis detected several redundant constructs across the codebase. Most of the ones fixed here are marked as warnings/weak warnings, likely code smells post-migration from Java. Doing another small round to clean up some of them. ## Changelog: [INTERNAL] - Kotlin: Clean up redundant constructs Pull Request resolved: #51170 Test Plan: ```sh yarn android yarn test-android ``` Reviewed By: rshest Differential Revision: D74381864 Pulled By: cortinico fbshipit-source-id: 25244cdf384875f7cc4e2d091c8b247710de5ecf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Static code analysis detected several redundant constructs across the codebase. Most of the ones fixed here are marked as warnings/weak warnings, likely code smells post-migration from Java.
Doing a small round to clean up some of them.
Changelog:
[INTERNAL] - Kotlin: Clean up redundant constructs
Test Plan: