fix(iOS): enable DEFINES_MODULE in React-jsc
#51160
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
Have you tried using the community package? |
cipolleschi
approved these changes
May 7, 2025
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in 473e42b. |
Collaborator
|
This pull request was successfully merged by @krozniata in 473e42b When will my fix make it into a release? | How to file a pick request? |
react-native-bot
pushed a commit
that referenced
this pull request
May 12, 2025
Summary: Enables `DEFINES_MODULE` in `React-jsc.podspec` After upgrading app to RN `0.79`, when installing pods with JSC enabled there is an error being thrown that `The following Swift pods cannot yet be integrated as static libraries` `The Swift pod 'RNFlashList' depends upon 'React-jsc', which does not define modules. ...` when installing packages that use Swift ## Changelog: [IOS] [CHANGED] - enable `DEFINES_MODULE` in `React-jsc.podspec` Pull Request resolved: #51160 Test Plan: RNTester runs and builds correctly Reviewed By: huntie Differential Revision: D74325357 Pulled By: cipolleschi fbshipit-source-id: b994b7e678633440d5e362ae6965b2d5188d34f1
Collaborator
|
This pull request was successfully merged by @krozniata in 1c22a46 When will my fix make it into a release? | How to file a pick request? |
react-native-bot
pushed a commit
that referenced
this pull request
Jun 4, 2025
Summary: Enables `DEFINES_MODULE` in `React-jsc.podspec` After upgrading app to RN `0.79`, when installing pods with JSC enabled there is an error being thrown that `The following Swift pods cannot yet be integrated as static libraries` `The Swift pod 'RNFlashList' depends upon 'React-jsc', which does not define modules. ...` when installing packages that use Swift ## Changelog: [IOS] [CHANGED] - enable `DEFINES_MODULE` in `React-jsc.podspec` Pull Request resolved: #51160 Test Plan: RNTester runs and builds correctly Reviewed By: huntie Differential Revision: D74325357 Pulled By: cipolleschi fbshipit-source-id: b994b7e678633440d5e362ae6965b2d5188d34f1
Collaborator
|
This pull request was successfully merged by @krozniata in c8fcac2 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enables
DEFINES_MODULEinReact-jsc.podspecAfter upgrading app to RN
0.79, when installing pods with JSC enabled there is an error being thrown thatThe following Swift pods cannot yet be integrated as static librariesThe Swift pod 'RNFlashList' depends upon 'React-jsc', which does not define modules. ...when installing packages that use Swift
Changelog:
[IOS] [CHANGED] - enable
DEFINES_MODULEinReact-jsc.podspecTest Plan:
RNTester runs and builds correctly