RN: Migrate to ESM - Libraries/Components/Image #51434
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: facebook#51416 Deletes `oncall` annotations from the `facebook/react-native` repository. Changelog: [Internal] Reviewed By: javache Differential Revision: D74902524
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74943031 |
Summary: Fixes a bunch of ESLint warnings across the codebase. The only remaining warnings are from the `lint/no-commonjs-exports` rule. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74942686
Summary: Migrates files to use ESM to mitigate the existing lint warning. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74942792
Summary: Migrates files to use ESM to mitigate the existing lint warning. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74942842
Summary: This `ErrorUtils` mock is dead code. There is no `ErrorUtils` module in React Native. (Maybe there was once upon a time...) Changelog: [Internal] Differential Revision: D74942884
Summary: Pull Request resolved: facebook#51434 Migrates files to use ESM to mitigate the existing lint warning. I am suppressing `RelativeImageStub` to preserve compatibility with the dynamic asset exports generated by Metro (i.e. not ESM with `default` exports). Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74943031
|
This pull request was exported from Phabricator. Differential Revision: D74943031 |
yungsters
force-pushed
the
export-D74943031
branch
from
2b1f0f4 to
97109a0
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 18, 2025
Summary: Migrates files to use ESM to mitigate the existing lint warning. I am suppressing `RelativeImageStub` to preserve compatibility with the dynamic asset exports generated by Metro (i.e. not ESM with `default` exports). Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74943031
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 18, 2025
Summary: Migrates files to use ESM to mitigate the existing lint warning. I am suppressing `RelativeImageStub` to preserve compatibility with the dynamic asset exports generated by Metro (i.e. not ESM with `default` exports). Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74943031
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 18, 2025
Summary: Migrates files to use ESM to mitigate the existing lint warning. I am suppressing `RelativeImageStub` to preserve compatibility with the dynamic asset exports generated by Metro (i.e. not ESM with `default` exports). Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74943031
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 18, 2025
Summary: Migrates files to use ESM to mitigate the existing lint warning. I am suppressing `RelativeImageStub` to preserve compatibility with the dynamic asset exports generated by Metro (i.e. not ESM with `default` exports). Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74943031
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 18, 2025
Summary: Migrates files to use ESM to mitigate the existing lint warning. I am suppressing `RelativeImageStub` to preserve compatibility with the dynamic asset exports generated by Metro (i.e. not ESM with `default` exports). Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74943031
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 18, 2025
Summary: Migrates files to use ESM to mitigate the existing lint warning. I am suppressing `RelativeImageStub` to preserve compatibility with the dynamic asset exports generated by Metro (i.e. not ESM with `default` exports). Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74943031
|
This pull request was successfully merged by @yungsters in f169754 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Migrates files to use ESM to mitigate the existing lint warning.
I am suppressing
RelativeImageStubto preserve compatibility with the dynamic asset exports generated by Metro (i.e. not ESM withdefaultexports).Changelog:
[Internal]
Differential Revision: D74943031