Refactor existing native module into a general purpose native module for Fantom test specific methods #51133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73997209 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73997209 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 7, 2025
…for Fantom test specific methods (facebook#51133) Summary: Pull Request resolved: facebook#51133 Changelog: [internal] Having a single native module with all the test-specific functionality that we need in native in Fantom is just more convenient. Differential Revision: D73997209
rubennorte
force-pushed
the
export-D73997209
branch
from
9eca098 to
9a9b37e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73997209 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 7, 2025
…for Fantom test specific methods (facebook#51133) Summary: Pull Request resolved: facebook#51133 Changelog: [internal] Having a single native module with all the test-specific functionality that we need in native in Fantom is just more convenient. Reviewed By: rshest, huntie Differential Revision: D73997209
rubennorte
force-pushed
the
export-D73997209
branch
from
9a9b37e to
84ceb6a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73997209 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 7, 2025
…for Fantom test specific methods (facebook#51133) Summary: Pull Request resolved: facebook#51133 Changelog: [internal] Having a single native module with all the test-specific functionality that we need in native in Fantom is just more convenient. Reviewed By: rshest, huntie Differential Revision: D73997209
rubennorte
force-pushed
the
export-D73997209
branch
from
84ceb6a to
5e761c2
Compare
…for Fantom test specific methods (facebook#51133) Summary: Pull Request resolved: facebook#51133 Changelog: [internal] Having a single native module with all the test-specific functionality that we need in native in Fantom is just more convenient. Reviewed By: rshest, huntie Differential Revision: D73997209
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73997209 |
rubennorte
force-pushed
the
export-D73997209
branch
from
5e761c2 to
1b4ef83
Compare
Contributor
|
This pull request has been merged in 759652b. |
Collaborator
|
This pull request was successfully merged by @rubennorte in 759652b When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Having a single native module with all the test-specific functionality that we need in native in Fantom is just more convenient.
Differential Revision: D73997209