IntersectionObserver: Switch from ShadowNode to ShadowNodeFamily
#51089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74130479 |
yungsters
force-pushed
the
export-D74130479
branch
from
ac252b3 to
92a68aa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74130479 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 6, 2025
…acebook#51089) Summary: Currently, `IntersectionObserver#observe` retains a reference to the `ShadowNode` of the view that is supplied as an argument, which is used to compute intersection whenever a shadow tree is committed. However, the `shadowNode` includes all of child nodes and state at the time that `IntersectionObserver#observe` is called. This means that an active `IntersectionObserverEntry` will retain references to memory that would otherwise be deallocated (e.g. if children of the observed view are unmounted after `IntersectionObserver#observe` is called). This diff refactors `IntersectionObserver` to instead retain a reference to the `ShadowNodeFamily`, which does not retain references to child nodes and still eanbles `IntersectionObserver` to compute intersections. Changelog: [General][Changed] - Fixed `IntersectionObserver#observe` to avoid retaining memory for unmounted child nodes of observed views. Differential Revision: D74130479
yungsters
force-pushed
the
export-D74130479
branch
from
92a68aa to
761107c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74130479 |
yungsters
force-pushed
the
export-D74130479
branch
from
761107c to
e21a559
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 6, 2025
…acebook#51089) Summary: Currently, `IntersectionObserver#observe` retains a reference to the `ShadowNode` of the view that is supplied as an argument, which is used to compute intersection whenever a shadow tree is committed. However, the `shadowNode` includes all of child nodes and state at the time that `IntersectionObserver#observe` is called. This means that an active `IntersectionObserverEntry` will retain references to memory that would otherwise be deallocated (e.g. if children of the observed view are unmounted after `IntersectionObserver#observe` is called). This diff refactors `IntersectionObserver` to instead retain a reference to the `ShadowNodeFamily`, which does not retain references to child nodes and still eanbles `IntersectionObserver` to compute intersections. Changelog: [General][Changed] - Fixed `IntersectionObserver#observe` to avoid retaining memory for unmounted child nodes of observed views. Differential Revision: D74130479
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 6, 2025
…acebook#51089) Summary: Currently, `IntersectionObserver#observe` retains a reference to the `ShadowNode` of the view that is supplied as an argument, which is used to compute intersection whenever a shadow tree is committed. However, the `shadowNode` includes all of child nodes and state at the time that `IntersectionObserver#observe` is called. This means that an active `IntersectionObserverEntry` will retain references to memory that would otherwise be deallocated (e.g. if children of the observed view are unmounted after `IntersectionObserver#observe` is called). This diff refactors `IntersectionObserver` to instead retain a reference to the `ShadowNodeFamily`, which does not retain references to child nodes and still eanbles `IntersectionObserver` to compute intersections. Changelog: [General][Changed] - Fixed `IntersectionObserver#observe` to avoid retaining memory for unmounted child nodes of observed views. Differential Revision: D74130479
yungsters
force-pushed
the
export-D74130479
branch
from
e21a559 to
e9bb16d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74130479 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 6, 2025
…acebook#51089) Summary: Pull Request resolved: facebook#51089 Currently, `IntersectionObserver#observe` retains a reference to the `ShadowNode` of the view that is supplied as an argument, which is used to compute intersection whenever a shadow tree is committed. However, the `shadowNode` includes all of child nodes and state at the time that `IntersectionObserver#observe` is called. This means that an active `IntersectionObserverEntry` will retain references to memory that would otherwise be deallocated (e.g. if children of the observed view are unmounted after `IntersectionObserver#observe` is called). This diff refactors `IntersectionObserver` to instead retain a reference to the `ShadowNodeFamily`, which does not retain references to child nodes and still eanbles `IntersectionObserver` to compute intersections. Changelog: [General][Changed] - Fixed `IntersectionObserver#observe` to avoid retaining memory for unmounted child nodes of observed views. Differential Revision: D74130479
yungsters
force-pushed
the
export-D74130479
branch
from
e9bb16d to
10f6aff
Compare
…acebook#51089) Summary: Pull Request resolved: facebook#51089 Currently, `IntersectionObserver#observe` retains a reference to the `ShadowNode` of the view that is supplied as an argument, which is used to compute intersection whenever a shadow tree is committed. However, the `shadowNode` includes all of child nodes and state at the time that `IntersectionObserver#observe` is called. This means that an active `IntersectionObserverEntry` will retain references to memory that would otherwise be deallocated (e.g. if children of the observed view are unmounted after `IntersectionObserver#observe` is called). This diff refactors `IntersectionObserver` to instead retain a reference to the `ShadowNodeFamily`, which does not retain references to child nodes and still eanbles `IntersectionObserver` to compute intersections. Changelog: [General][Changed] - Fixed `IntersectionObserver#observe` to avoid retaining memory for unmounted child nodes of observed views. Differential Revision: D74130479
|
This pull request was exported from Phabricator. Differential Revision: D74130479 |
yungsters
force-pushed
the
export-D74130479
branch
from
10f6aff to
c6bfab1
Compare
|
This pull request has been merged in d945c58. |
|
This pull request was successfully merged by @yungsters in d945c58 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently,
IntersectionObserver#observeretains a reference to theShadowNodeof the view that is supplied as an argument, which is used to compute intersection whenever a shadow tree is committed.However, the
shadowNodeincludes all of child nodes and state at the time thatIntersectionObserver#observeis called. This means that an activeIntersectionObserverEntrywill retain references to memory that would otherwise be deallocated (e.g. if children of the observed view are unmounted afterIntersectionObserver#observeis called).This diff refactors
IntersectionObserverto instead retain a reference to theShadowNodeFamily, which does not retain references to child nodes and still eanblesIntersectionObserverto compute intersections.Changelog:
[General][Changed] - Fixed
IntersectionObserver#observeto avoid retaining memory for unmounted child nodes of an observed view.Differential Revision: D74130479