Add missing ReplaceWith on deprecations
#51144
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor/add-missing-replace-with-on-deprecations
…ctor/add-missing-replace-with-on-deprecations
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
javache
reviewed
May 7, 2025
|
|
||
| internal class FabricEventEmitter(private val uiManager: FabricUIManager) : RCTModernEventEmitter { | ||
| @Deprecated("Deprecated in Java") | ||
| @Deprecated("Deprecated in Java", ReplaceWith("receiveEvent(ViewUtil.NO_SURFACE_ID, targetTag, eventName, params)")) |
Member
There was a problem hiding this comment.
This is not the right replacement. NO_SURFACE_ID will likely cause the event to be dropped.
Collaborator
Author
Contributor
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Collaborator
|
This pull request was successfully merged by @mateoguzmana in 84253c4 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Static code analysis detected several missing
ReplaceWithon deprecated methods. This diff addresses some of them by adding the most accurate suggestions based on the implementations.Changelog:
[INTERNAL] - Add missing ReplaceWith on deprecations
Test Plan: