hermes-engine should build with target Java version 17 #51162
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74325107 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
May 7, 2025
Summary: We specify the java target version to 17 for ReactAndroid but not for hermes-engine. This is causing it to be the default (8) which will cause our build to fail on JDK 21. This fixes it. Changelog: [Internal] [Changed] - Differential Revision: D74325107
cortinico
force-pushed
the
export-D74325107
branch
from
b57be83 to
53f9347
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
May 7, 2025
Summary: We specify the java target version to 17 for ReactAndroid but not for hermes-engine. This is causing it to be the default (8) which will cause our build to fail on JDK 21. This fixes it. Changelog: [Internal] [Changed] - Differential Revision: D74325107
cortinico
force-pushed
the
export-D74325107
branch
from
53f9347 to
8e1c1d1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74325107 |
Summary: Pull Request resolved: facebook#51162 We specify the java target version to 17 for ReactAndroid but not for hermes-engine. This is causing it to be the default (8) which will cause our build to fail on JDK 21. This fixes it. Changelog: [Internal] [Changed] - Differential Revision: D74325107
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74325107 |
cortinico
force-pushed
the
export-D74325107
branch
from
8e1c1d1 to
e4e7c09
Compare
Contributor
|
This pull request has been merged in db18aac. |
Collaborator
|
This pull request was successfully merged by @cortinico in db18aac When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We specify the java target version to 17 for ReactAndroid but not for hermes-engine.
This is causing it to be the default (8) which will cause our build to fail on JDK 21.
This fixes it.
Changelog:
[Internal] [Changed] -
Differential Revision: D74325107