Fix: Text component pressRetentionOffset issue on Windows

[iamAbhi-916]

Description

Text component pressRetentionOffset on Windows wasnt working as expected behaviour as it is on native components

Problem:
PressRetentionOffset implementation is wasnt working correctly for windows.
(Expected behaviour )-> allowing touches to remain active within the expanded area while canceling them when moving beyond it.

1> when press is moved away from retention offset , it wasnt cancelling then .
2> JS side was handling in pressability and this was hooked to text using usePressability but the issue was that the
PressRetentionOffset  was called within onResponderMove which was never triggered from native side .


Fix:
1>When a component claims responder status (via onStartShouldSetResponder), the pointer is marked as an "active touch"
2>As that pointer moves across the screen, all move events are correctly dispatched to JavaScript
3> This allows the Pressability component in JavaScript to properly track the movement and apply the pressRetentionOffset logic

Type of Change

New feature (non-breaking change which adds functionality)

Why

the current code wasn't dispatching pointer move events through the touch event system for active touches with responders. The touch event system is what RNW uses to track touch interactions.

Resolves [Add Relevant Issue Here]
#13837

What

1>When a component claims responder status (via onStartShouldSetResponder), the pointer is marked as an "active touch"
2>As that pointer moves across the screen, all move events are correctly dispatched to JavaScript
3> This allows the Pressability component in JavaScript to properly track the movement and apply the pressRetentionOffset logic

Screenshots

pressOffsetrect_fix.mp4

Testing

using playground

import React from 'react';
import {
  StyleSheet,
  View,
  AppRegistry,
} from 'react-native';
import {Text} from 'react-native-windows';

const App = () => {
  const handlePressIn = () => console.log('🔵 Press In');
  const handlePressOut = () => console.log('🟡 Press Out');
  const handlePress = () => console.log('🟢 Press');
  return (
    <View style={styles.container}>
      <View style={styles.retentionZone}>
        <Text
          style={styles.pressableText}
          pressRetentionOffset={{top: 30, bottom: 30, left: 30, right: 30}}
          onPressIn={handlePressIn}
          onPressOut={handlePressOut}
          onPress={handlePress}>
          Tap and move slightly to test pressRetentionOffset
        </Text>
      </View>
    </View>
  );
};

Changelog

yes

Add a brief summary of the change to use in the release notes for the next release.

Text component pressRetentionOffset on Windows is added : allowing touches to remain active within the expanded area while canceling them when moving beyond it.

[acoates-ms]

Do we need to remove the hasMoveEventListeners check here? Isn't there a perf cost to this (now all move events will always have to be fired and propagated to JS, even if no-one is listening?

[iamAbhi-916]

only applies to active touches that have already claimed responder status - not to all pointer moves so sending these extra events for ongoing interactions, which is actually a small subset of all pointer movements

[acoates-ms]

It looks like pressRetentionOffset isn't supported on Text in core. It is a property on Pressable, not view/text.

Does it work on Pressable already? -- Is this change even needed?

[iamAbhi-916]

It looks like pressRetentionOffset isn't supported on Text in core. It is a property on Pressable, not view/text.

Does it work on Pressable already? -- Is this change even needed?

so Official react docs explicitly lists pressRetentionOffset as a prop for [Text] components, showing that the functionality
When the touch is released outside this view, the press gesture continues to be detected, and onPress is triggered.

core support : on both iOS and Android this is supported , making Windows inconsistent without it.
so this should be added so that Users expect the same touch behavior across platforms

[acoates-ms]

This looks like a bug in core. -- This property should be added to Text.d.ts upstream.
Fine to add it here too.. but we should open a PR in RN to add this.

[iamAbhi-916]

yeah this a bug , they are handling it textprops.js file but didnt add as a prop ins text.d.ts file