Skip to content

Deprecate SUPPORT_* constants for color_mode#69269

Merged
emontnemery merged 11 commits intohome-assistant:devfrom
epenet:deprecate-support-brightness
Sep 9, 2022
Merged

Deprecate SUPPORT_* constants for color_mode#69269
emontnemery merged 11 commits intohome-assistant:devfrom
epenet:deprecate-support-brightness

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Apr 4, 2022

Proposed change

Follow-up to #47720

ℹ️ tracking PR until their use has been removed

Needs:

Implemented:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added code-quality small-pr PRs with less than 30 lines. labels Apr 4, 2022
@epenet epenet marked this pull request as draft April 4, 2022 13:15
@ggravlingen
Copy link
Copy Markdown
Contributor

ggravlingen commented Apr 4, 2022

Nice! I've actually prepared a PR that drops all SUPPORT_ constants for the Tradfri integration and replaces them with color_mode and the new int enums. I will submit this PR once #69125 is merged.

@epenet epenet force-pushed the deprecate-support-brightness branch from 398cf6f to 2832197 Compare April 4, 2022 19:28
@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Apr 4, 2022

Nice! I've actually prepared a PR that drops all SUPPORT_ constants for the Tradfri integration and replaces them with color_mode and the new int enums. I will submit this PR once #69125 is merged.

Please note there are three separate PRs: #69269 (this one), #69301, #69302 corresponding to different types of deprecation.

@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Aug 30, 2022

Still needs mqtt and template...

@epenet epenet marked this pull request as ready for review September 8, 2022 13:32
@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Sep 8, 2022

After 5 months in the queue, this is finally ready to be merged.

@epenet epenet added the smash Indicator this PR is close to finish for merging or closing label Sep 8, 2022
@emontnemery emontnemery merged commit b369c2f into home-assistant:dev Sep 9, 2022
@epenet epenet deleted the deprecate-support-brightness branch September 9, 2022 09:27
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants