Migrate osramlightify light to color_mode#70915
Merged
Conversation
90 tasks
This comment was marked as outdated.
This comment was marked as outdated.
emontnemery
force-pushed
the
osramlightify_light_color_mode
branch
from
4810b0a to
cc585e0
Compare
emontnemery
commented
May 27, 2022
|
|
||
| if len(self._attr_supported_color_modes > 1): | ||
| # The light supports hs + color temp, determine which one it is | ||
| if self._rgb_color == (0, 0, 0): |
Contributor
Author
There was a problem hiding this comment.
The python-lightify library has DeviceSubType.LIGHT_RGBW which supports color + color temperature, so we need to determine which mode the light is in. The way it's done here is most likely not correct though.
@OleksandrBerchenko, @tfriedel how can we tell which mode a light which supports both color and tunable white is in?
Contributor
There was a problem hiding this comment.
@emontnemery I'm afraid I don't know and I don't have the time to dive into this atm.
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
frenck
approved these changes
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Migrate osramlightify light to color_mode
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: