Merged
Conversation
|
Hey there @pvizeli, @danielperna84, mind taking a look at this pull request as it has been labeled with an integration ( |
emontnemery
commented
Apr 4, 2022
Comment on lines
+63
to
+83
| def color_mode(self) -> str: | ||
| """Return the color mode of the light.""" | ||
| if "COLOR" in self._hmdevice.WRITENODE: | ||
| return COLOR_MODE_HS | ||
| if hasattr(self._hmdevice, "get_color_temp"): | ||
| return COLOR_MODE_COLOR_TEMP | ||
| return COLOR_MODE_BRIGHTNESS | ||
|
|
||
| @property | ||
| def supported_color_modes(self) -> set[str] | None: | ||
| """Flag supported color modes.""" | ||
| color_modes = set() | ||
|
|
||
| if "COLOR" in self._hmdevice.WRITENODE: | ||
| features |= SUPPORT_COLOR | ||
| color_modes.add(COLOR_MODE_HS) | ||
| if hasattr(self._hmdevice, "get_color_temp"): | ||
| color_modes.add(COLOR_MODE_COLOR_TEMP) | ||
| if not color_modes: | ||
| color_modes.add(COLOR_MODE_BRIGHTNESS) | ||
|
|
||
| return color_modes |
Contributor
Author
There was a problem hiding this comment.
This code is assuming:
- A homematic light's features can dynamically change, and is not necessarily known when the
HMLightobject instantiated - There are homematic lights which can support both hs color and color temperature
Looking at the code in pyhomematic, I think neither of this is true; IPKeySwitchLevel and ColorEffectLight supports hs color, but not color temperature, ColdWarmDimmer supports color temperature but not hs color and there's no light supporting both.
@danielperna84, @pvizeli can you confirm this is the case?
Member
There was a problem hiding this comment.
I don't know about the second one but the first one is wrong. Nothing is dynamic, all is known after the HMLight object is created
90 tasks
pvizeli
approved these changes
Apr 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Migrate homematic light to color_mode
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: