Skip to content

Add light SUPPORT_* to deprecated imports#69228

Closed
epenet wants to merge 5 commits intohome-assistant:devfrom
epenet:pylint-imports
Closed

Add light SUPPORT_* to deprecated imports#69228
epenet wants to merge 5 commits intohome-assistant:devfrom
epenet:pylint-imports

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Apr 4, 2022

Proposed change

As follow-up to #69103

Sample result:

************* Module homeassistant.components.osramlightify.light
Warning: homeassistant/components/osramlightify/light.py:10:0: W0012: SUPPORT_BRIGHTNESS is deprecated, replaced by color modes (hass-deprecated-import)
Warning: homeassistant/components/osramlightify/light.py:10:0: W0012: SUPPORT_COLOR is deprecated, replaced by color modes (hass-deprecated-import)
Warning: homeassistant/components/osramlightify/light.py:10:0: W0012: SUPPORT_COLOR_TEMP is deprecated, replaced by color modes (hass-deprecated-import)
Warning: homeassistant/components/osramlightify/light.py:10:0: W0012: SUPPORT_EFFECT is deprecated, replaced by LightEntityFeature enum (hass-deprecated-import)
Warning: homeassistant/components/osramlightify/light.py:10:0: W0012: SUPPORT_TRANSITION is deprecated, replaced by LightEntityFeature enum (hass-deprecated-import)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added code-quality small-pr PRs with less than 30 lines. labels Apr 4, 2022
@frenck
Copy link
Copy Markdown
Member

frenck commented Apr 4, 2022

Nice! You could also add the DEVICE_CLASS_*, those have been deprecated too

@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Apr 4, 2022

Nice! You could also add the DEVICE_CLASS_*, those have been deprecated too

Yes, I think I need to start with some older constants, that have long been deprecated, and should already be mostly cleaned up.
Then add these newly deprecated constants gradually.

@epenet epenet changed the title Add pylint plugin for deprecated imports Add light SUPPORT_* to deprecated imports Apr 4, 2022
@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Apr 4, 2022

Closing in favour of #69269 and #69301

@epenet epenet closed this Apr 4, 2022
@epenet epenet deleted the pylint-imports branch April 4, 2022 19:35
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants