Skip to content

Migrate xiaomi_miio light to color_mode#70998

Merged
emontnemery merged 1 commit intodevfrom
xiaomi_miio_light_color_mode
May 27, 2022
Merged

Migrate xiaomi_miio light to color_mode#70998
emontnemery merged 1 commit intodevfrom
xiaomi_miio_light_color_mode

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Apr 28, 2022

Proposed change

Migrate `xiaomi_miio light to color_mode

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@emontnemery emontnemery marked this pull request as draft April 28, 2022 12:24
@probot-home-assistant
Copy link
Copy Markdown

Hey there @rytilahti, @syssi, @starkillerOG, @bieniu, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

return SUPPORT_BRIGHTNESS | SUPPORT_COLOR | SUPPORT_COLOR_TEMP
def color_mode(self):
"""Return the color mode of the light."""
if self.hs_color:
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the same behavior as without the PR.
I don't think it's really correct though; the light will be stuck in hs mode once a color is set.

Does the miio library offer any way to get the color mode for a PhilipsMoonlight?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The library does not provide that at the moment and I'm not sure if it can be derived from the data returned by the device. Maybe @syssi knows if that's even possible?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rytilahti @syssi If the library offers no way to get the color mode I suggest to merge this PR, it should not result in any changed behavior

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine as an (intermediate) solution.

@emontnemery emontnemery marked this pull request as ready for review May 27, 2022 06:36
@emontnemery emontnemery merged commit cc42a95 into dev May 27, 2022
@emontnemery emontnemery deleted the xiaomi_miio_light_color_mode branch May 27, 2022 06:36
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants