Add color_mode support to group light#50165
Merged
balloob merged 3 commits intohome-assistant:devfrom May 7, 2021
Merged
Conversation
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration ( |
emontnemery
commented
May 6, 2021
Comment on lines
+382
to
+387
| self._color_mode = None | ||
| all_color_modes = list(_find_state_attributes(on_states, ATTR_COLOR_MODE)) | ||
| if all_color_modes: | ||
| # Report the most common color mode. | ||
| color_mode_count = Counter(itertools.chain(all_color_modes)) | ||
| self._color_mode = color_mode_count.most_common(1)[0][0] |
Contributor
Author
There was a problem hiding this comment.
This could maybe be a little bit smarter: Select the color_mode using the most channels among the color modes used by the group.
balloob
approved these changes
May 7, 2021
frenck
pushed a commit
that referenced
this pull request
May 7, 2021
* Add color_mode support to group light * Lint * Update tests
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add color_mode support to group light
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: