Skip to content

Migrate rflink light to color_mode#69532

Merged
emontnemery merged 2 commits intohome-assistant:devfrom
epenet:light-mode-rflink
Apr 7, 2022
Merged

Migrate rflink light to color_mode#69532
emontnemery merged 2 commits intohome-assistant:devfrom
epenet:light-mode-rflink

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Apr 7, 2022

Proposed change

Follow-up to #47720, needed for #69269

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @javicalle, mind taking a look at this pull request as it has been labeled with an integration (rflink) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the non-dimmable lights to set:

    _attr_color_mode = COLOR_MODE_ONOFF
    _attr_supported_color_modes = {COLOR_MODE_ONOFF}

@javicalle
Copy link
Copy Markdown
Contributor

Please update the non-dimmable lights to set:

    _attr_color_mode = COLOR_MODE_ONOFF
    _attr_supported_color_modes = {COLOR_MODE_ONOFF}

Also in RflinkLight:

class RflinkLight(SwitchableRflinkDevice, LightEntity):
"""Representation of a Rflink light."""

(It would seem that the hierarchy could be optimized)

Copy link
Copy Markdown
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @epenet 👍

@emontnemery emontnemery merged commit 75b1760 into home-assistant:dev Apr 7, 2022
@epenet epenet deleted the light-mode-rflink branch April 7, 2022 07:40
@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Apr 7, 2022

It would seem that the hierarchy could be optimized

@javicalle I suggest that you create the follow-up PR as you are more familiar with the integration

@javicalle
Copy link
Copy Markdown
Contributor

Sorry, but RflinkLight also must be fixed (the COLOR_MODE_ part).

emontnemery added a commit that referenced this pull request Apr 7, 2022
@epenet epenet mentioned this pull request Apr 7, 2022
22 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants