Migrate rflink light to color_mode#69532
Merged
emontnemery merged 2 commits intohome-assistant:devfrom Apr 7, 2022
Merged
Conversation
|
Hey there @javicalle, mind taking a look at this pull request as it has been labeled with an integration ( |
90 tasks
emontnemery
requested changes
Apr 7, 2022
Contributor
emontnemery
left a comment
There was a problem hiding this comment.
Please update the non-dimmable lights to set:
_attr_color_mode = COLOR_MODE_ONOFF
_attr_supported_color_modes = {COLOR_MODE_ONOFF}
Contributor
Also in core/homeassistant/components/rflink/light.py Lines 174 to 177 in 109bde4 (It would seem that the hierarchy could be optimized) |
Contributor
Author
@javicalle I suggest that you create the follow-up PR as you are more familiar with the integration |
Contributor
|
Sorry, but |
emontnemery
added a commit
that referenced
this pull request
Apr 7, 2022
This reverts commit 75b1760.
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Follow-up to #47720, needed for #69269
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: