Skip to content

Cleanup constants in Tradfri integration#69125

Merged
MartinHjelmare merged 18 commits intohome-assistant:devfrom
ggravlingen:tradfri_move_constant
Apr 5, 2022
Merged

Cleanup constants in Tradfri integration#69125
MartinHjelmare merged 18 commits intohome-assistant:devfrom
ggravlingen:tradfri_move_constant

Conversation

@ggravlingen
Copy link
Copy Markdown
Contributor

@ggravlingen ggravlingen commented Apr 2, 2022

Proposed change

Proposing this minor cleanup of contants:

  • Move all constants to the models where they are used.
  • Move _LOGGER to const.py
  • Order const.py alphabetically
  • Remove unused constants

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@ggravlingen ggravlingen marked this pull request as ready for review April 2, 2022 10:33
@ggravlingen
Copy link
Copy Markdown
Contributor Author

In a follow-up, I will refactor the SUPPORTED_ constants that I've seen are not deprecated.

@ggravlingen
Copy link
Copy Markdown
Contributor Author

Just noticed there are remnants from the groups import in the config flow. I will adress that separately when this has been merged.

@ggravlingen ggravlingen changed the title Refactor constants Cleanup constants in Tradfri integration Apr 2, 2022
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 04fc3a1 into home-assistant:dev Apr 5, 2022
@ggravlingen ggravlingen deleted the tradfri_move_constant branch April 5, 2022 12:08
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants