Conversation
| return self._fixed_color_mode | ||
|
|
||
| # The light supports both hs and white with adjustable color temperature | ||
| if self._effect == EFFECT_NIGHT or self._color is None or self._color[1] == 0: |
There was a problem hiding this comment.
This is copying the condition from the hs_color attribute, which was previously gated by checking if the saturation was 0. @smwa can you help confirm that's the correct way to determine the current mode of the light (color or white with adjustable color temperature)?
| return self._fixed_color_mode | ||
|
|
||
| # The light supports both hs and white with adjustable color temperature | ||
| if self._effect == EFFECT_NIGHT or self._color is None or self._color[1] == 0: |
| COLOR_MODES_LIMITLESS_DIMMER = {COLOR_MODE_BRIGHTNESS} | ||
| SUPPORT_LIMITLESSLED_DIMMER = SUPPORT_TRANSITION | ||
| COLOR_MODES_LIMITLESS_RGB = {COLOR_MODE_HS} | ||
| SUPPORT_LIMITLESSLED_RGB = SUPPORT_EFFECT | SUPPORT_FLASH | SUPPORT_TRANSITION |
There was a problem hiding this comment.
Several of these will no longer have SUPPORT_BRIGHTNESS. Is that assumed from SUPPORT_TRANSITION, or does this assume that all bulb types have brightness?
There was a problem hiding this comment.
The SUPPORT_BRIGHTNESS flag is deprecated, brightness support is instead implied the color modes: https://developers.home-assistant.io/docs/core/entity/light#color-modes.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
emontnemery
force-pushed
the
limitlessled_light_color_mode
branch
from
9483c03 to
dfaba85
Compare
|
Set to "ready for review", thanks @smwa for the feedback 👍 |
5 participants
Proposed change
Migrate limitlessled light to color_mode
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: