Skip to content

Migrate hue v1 light to color_mode#69275

Merged
emontnemery merged 4 commits intodevfrom
hue_light_v1_color_mode
Apr 28, 2022
Merged

Migrate hue v1 light to color_mode#69275
emontnemery merged 4 commits intodevfrom
hue_light_v1_color_mode

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

Proposed change

Migrate hue v1 light to color_mode

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (light) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @balloob, @marcelveldt, mind taking a look at this pull request as it has been labeled with an integration (hue) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@emontnemery
Copy link
Copy Markdown
Contributor Author

@marcelveldt This could be done a bit nicer, for example use XY-color mode instead when the light is in that mode instead of converting to HS

Copy link
Copy Markdown
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcelveldt
Copy link
Copy Markdown
Member

marcelveldt commented Apr 26, 2022

@marcelveldt This could be done a bit nicer, for example use XY-color mode instead when the light is in that mode instead of converting to HS

Considered the fact this is deprecated V1 API I wouldn't waste too much energy on it tbh as all dev energy goes to the V2 implementation so it is fine as it is once the test is fixed

@frenck
Copy link
Copy Markdown
Member

frenck commented Apr 26, 2022

Considered the fact this is deprecated V1 API I wouldn't waste too much energy on it tbh as all dev energy goes to the V2 implementation

Well, the reason is that we want to deprecate supported features for the light platform in favor of the color modes. We need to migrate all core integrations in order to do that.

@marcelveldt
Copy link
Copy Markdown
Member

marcelveldt commented Apr 26, 2022

Well, the reason is that we want to deprecate supported features for the light platform in favor of the color modes. We need to migrate all core integrations in order to do that.

Sorry, the quote was missing in the reply. I was replying on the text that it could be done nicer.

@emontnemery emontnemery force-pushed the hue_light_v1_color_mode branch from 0439912 to f6b2be5 Compare April 26, 2022 13:42
@emontnemery emontnemery merged commit 573e966 into dev Apr 28, 2022
@emontnemery emontnemery deleted the hue_light_v1_color_mode branch April 28, 2022 07:49
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants