Conversation
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @balloob, @marcelveldt, mind taking a look at this pull request as it has been labeled with an integration ( |
|
@marcelveldt This could be done a bit nicer, for example use XY-color mode instead when the light is in that mode instead of converting to HS |
Considered the fact this is deprecated V1 API I wouldn't waste too much energy on it tbh as all dev energy goes to the V2 implementation so it is fine as it is once the test is fixed |
Well, the reason is that we want to deprecate supported features for the light platform in favor of the color modes. We need to migrate all core integrations in order to do that. |
Sorry, the quote was missing in the reply. I was replying on the text that it could be done nicer. |
0439912 to
f6b2be5
Compare
Proposed change
Migrate hue v1 light to color_mode
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: