Skip to content

Migrate smartthings light to color_mode#70968

Merged
frenck merged 2 commits intodevfrom
smartthings_light_color_mode
Aug 30, 2022
Merged

Migrate smartthings light to color_mode#70968
frenck merged 2 commits intodevfrom
smartthings_light_color_mode

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

Proposed change

Migrate smartthings light to color_mode

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @andrewsayre, mind taking a look at this pull request as it has been labeled with an integration (smartthings) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@emontnemery
Copy link
Copy Markdown
Contributor Author

@andrewsayre Can you help review + test this change?

Comment on lines +198 to +201
# The light supports hs + color temp, determine which one it is
if self._hs_color and self._hs_color[1]:
return ColorMode.HS
return ColorMode.COLOR_TEMP
Copy link
Copy Markdown
Contributor Author

@emontnemery emontnemery Apr 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find anything in the pysmartthings which helps determine which mode a light is in. This code may not be wanted, because setting the light to a hs-color with 0 saturation will make the light report itself being in CT mode.

@andrewsayre could you confirm what value the library reports in the status updates when setting the light to a color or a color temperature?

@emontnemery
Copy link
Copy Markdown
Contributor Author

Does this suggests there may be a colorMode attribute https://github.com/hongtat/smartthings-capabilities/blob/master/json/colorMode.json ?

@epenet

This comment was marked as outdated.

@emontnemery emontnemery force-pushed the smartthings_light_color_mode branch from 8535075 to 9475dca Compare May 13, 2022 08:30
@emontnemery emontnemery force-pushed the smartthings_light_color_mode branch from 9475dca to 5a63a1a Compare July 11, 2022 09:33
@emontnemery emontnemery marked this pull request as ready for review August 30, 2022 17:32
@emontnemery emontnemery reopened this Aug 30, 2022
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@frenck frenck merged commit 8936c91 into dev Aug 30, 2022
@frenck frenck deleted the smartthings_light_color_mode branch August 30, 2022 18:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants