Conversation
|
Hey there @andrewsayre, mind taking a look at this pull request as it has been labeled with an integration ( |
|
@andrewsayre Can you help review + test this change? |
| # The light supports hs + color temp, determine which one it is | ||
| if self._hs_color and self._hs_color[1]: | ||
| return ColorMode.HS | ||
| return ColorMode.COLOR_TEMP |
There was a problem hiding this comment.
I could not find anything in the pysmartthings which helps determine which mode a light is in. This code may not be wanted, because setting the light to a hs-color with 0 saturation will make the light report itself being in CT mode.
@andrewsayre could you confirm what value the library reports in the status updates when setting the light to a color or a color temperature?
|
Does this suggests there may be a |
This comment was marked as outdated.
This comment was marked as outdated.
8535075 to
9475dca
Compare
9475dca to
5a63a1a
Compare
Proposed change
Migrate
smartthingslight tocolor_modeType of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: