Conditional feed upload scheduling

[nrostrow-meta]

Description

This PR makes the following changes:

• Updates AbstractFeed.php to only have feed uploads that extend it scheduled/regenerated if CPI ID is set for the instance as CPI ID is required for the API call to GraphCommercePartnerIntegrationFileUpdatePost
  • This ensures that the feed uploads will only be run after onboarding is complete as CPI ID is set after onboarding
  • should_skip_feed can be overwritten for future feeds that don't hit the GraphCommercePartnerIntegrationFileUpdatePost endpoint and have different requirements
• Adds calls to logExceptionImmediatelyToMeta and logTelemetryToMeta throughout the feed upload flow to persist logs to Meta
• Creates AbstractFeedTest.php to add some unit tests for the AbstractFeed.php logic

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Test instructions

Verified that the ratings and reviews feed upload works as expected after the changes

1. Pushed changes to my lightsail instance
2. Triggered the ratings and reviews feed upload by running the pending wc_facebook_regenerate_feed_ratings_and_reviews action
   
   
3. Verified that there was a log for the API call to GraphCommercePartnerIntegrationFileUpdatePost for the feed upload
   
4. Verified that there was a successful feed upload session
   

Verified that the ratings and reviews feed upload is not run if CPI ID isn't set for the instance

1. Locally modified should_skip_feed to always return true
2. Pushed changes to my lightsail instance
3. Tried to trigger the ratings and reviews feed upload by running the pending wc_facebook_regenerate_feed_ratings_and_reviews action
4. Verified that there were no logs for an API call to GraphCommercePartnerIntegrationFileUpdatePost and that there was no feed upload session created

Verified that the added logging calls work as expected

1. Locally modified start of each try block associated with the catch blocks that persists log to Meta to throw PluginException
2. Pushed changes to my lightsail instance
3. Verified that logs were persisted to Meta as expected
   
   
   
   
   

Verified that all tests in AbstractFeedTest.php pass as expected

1. Triggered all tests in AbstractFeedTest.php to run through PHPStorm
2. Verified that all the tests passed
   

Checklist

• I followed general Pull Request best practices. Meta employees to follow this wiki
• I have commented my code, particularly in hard-to-understand areas
• I have added tests and all the new and existing unit tests pass locally with my changes
• I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.

Changelog entry

Adding logging to feed upload flow and preventing feed uploads from being scheduled/regenerated until after CPI ID is set on the instance

[facebook-github-bot]

@nrostrow-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@nrostrow-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@nrostrow-meta merged this pull request in 41fae1d.