Skip to content

[LINTFIX] Lint fixes for includes/Framework/Plugin.php#3082

Closed
sol-loup wants to merge 1 commit intomainfrom
sollipse-lintfixes-4-23-B
Closed

[LINTFIX] Lint fixes for includes/Framework/Plugin.php#3082
sol-loup wants to merge 1 commit intomainfrom
sollipse-lintfixes-4-23-B

Conversation

@sol-loup
Copy link
Copy Markdown
Contributor

@sol-loup sol-loup commented Apr 23, 2025

Description

This PR fixes various lint issues in the includes/Framework/Plugin.php file without altering any existing behavior. The changes include:

  • Replacing the prohibited logical operator or with ||.
  • Adjusting whitespace, alignment, and spacing in multi-line function calls and variable assignments.
  • Updating doc comment formatting (e.g., ensuring proper capitalization and spacing between parameter type and variable).
  • Minor formatting tweaks for improved readability and consistency.

No functional behavior has been altered; these are purely syntax and style corrections to meet linting standards.

Type of change

  • Syntax change (non-breaking change which fixes code modularity, linting or PHPCS issues)

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have confirmed that my changes do not introduce any new PHPCS warnings or errors.
  • I have checked plugin debug logs to ensure my changes do not introduce any new PHP warnings or FATAL errors.
  • I followed general Pull Request best practices.
  • I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes.
  • I have completed dogfooding and QA testing, or have conducted thorough due diligence to ensure that it does not break existing functionality.
  • I have updated or requested an update to plugin documentation (if necessary).

Changelog entry

Fix lint issues and update code formatting in Plugin.php.

Test Plan

  1. Verify that the plugin functions normally without any new PHP warnings or errors.
  2. Run existing unit tests and confirm that they pass.
  3. Check that the formatting changes meet the linting rules without breaking any logic.

Screenshots

Before

(No screenshots available as these changes are purely syntax and formatting related.)

After

(No screenshots available as these changes are purely syntax and formatting related.)

@sol-loup sol-loup changed the title sollipse lintfixes 4 23 B Lint fixes for includes/Framework/Plugin.php Apr 23, 2025
@sol-loup sol-loup changed the title Lint fixes for includes/Framework/Plugin.php [LINTFIX] Lint fixes for includes/Framework/Plugin.php Apr 23, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@sol-loup has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@sol-loup merged this pull request in e9aed36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants