[LINTFIX] Lint fixes for Framework/Lifecycle.php

[sol-loup]

Description

This PR includes several code quality improvements and syntax fixes to the Lifecycle.php file:

• Replaced or with || for consistency with WordPress coding standards
• Improved code formatting and indentation
• Fixed array formatting and spacing
• Added proper PHPDoc type hints for array parameters
• Replaced json_encode() with wp_json_encode() for better WordPress compatibility
• Added PHPCS ignore comment for timestamp usage
• Improved SQL query formatting for better readability

Type of change

• Syntax change (non-breaking change which fixes code modularity, linting or phpcs issues)

Checklist

• I have commented my code, particularly in hard-to-understand areas.
• I have confirmed that my changes do not introduce any new PHPCS warnings or errors.
• I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors.
• I followed general Pull Request best practices.
• I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes.
• I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.
• I have updated or requested update to plugin documentations (if necessary).

Changelog entry

Code quality improvements and syntax fixes in Lifecycle class

Test Plan

1. Verified that all changes are syntax-only and don't affect functionality
2. Ran PHPCS to ensure no new warnings or errors
3. Tested plugin activation/deactivation to ensure lifecycle hooks still work
4. Verified milestone notices still display correctly
5. Checked that event history storage and retrieval functions properly

Screenshots

N/A - No visual changes

[facebook-github-bot]

@sol-loup has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@sol-loup merged this pull request in b434036.