Skip to content

[LINTFIX] Fixes for Dependencies.php#3132

Closed
sol-loup wants to merge 1 commit intomainfrom
sollipse-lintfixes-5-2-B
Closed

[LINTFIX] Fixes for Dependencies.php#3132
sol-loup wants to merge 1 commit intomainfrom
sollipse-lintfixes-5-2-B

Conversation

@sol-loup
Copy link
Copy Markdown
Contributor

@sol-loup sol-loup commented May 2, 2025

Description

This PR addresses linting issues in the Facebook for WooCommerce plugin, specifically in the Dependencies.php file. The changes improve code style, formatting, and PHP standards compliance.

Type of change

  • Syntax change (non-breaking change which fixes code modularity, linting or phpcs issues)

Checklist

  • I have confirmed that my changes do not introduce any new PHPCS warnings or errors.
  • I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors.
  • I followed general Pull Request best practices.

Changelog entry

Fixed linting issues in Dependencies class to improve code quality and standards compliance.

Test Plan

  1. Verified the code runs without errors
  2. Confirmed all functions work as expected after formatting changes
  3. Validated plugin functionality remains unchanged

Before

Code had linting issues including:

  • Using 'or' instead of '||'
  • Inconsistent parameter spacing
  • Improper multi-line function formatting
  • Missing text domain in translation functions
  • Inconsistent indentation

After

Code follows WordPress coding standards with:

  • Proper logical operators ('||')
  • Consistent parameter spacing
  • Properly formatted multi-line functions
  • Complete translation function calls
  • Consistent indentation

@sol-loup sol-loup changed the title sollipse lintfixes 5 2 B [LINTFIX] Fixes for Dependencies.php May 2, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@sol-loup has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@sol-loup merged this pull request in c4317b1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants