Feed upload logging update by nrostrow-meta · Pull Request #3192 · facebook/facebook-for-woocommerce

nrostrow-meta · 2025-05-15T01:51:31Z

Description

This PR ensures for the feed upload flows that anywhere we are calling fopen that we are calling fclose even if exceptions are thrown to prevent memory leak. This PR also adds some try/catch blocks to the feed upload file writing logic to persist exception data to Meta.

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist

I have commented my code, particularly in hard-to-understand areas.
I have confirmed that my changes do not introduce any new PHPCS warnings or errors.
I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors.
I followed general Pull Request best practices. Meta employees to follow this wiki.
I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes.
I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.
I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this wiki.

Changelog entry

Update feed upload file writing exception handling

Test Plan

Added throw new PluginException statements at the top of every added try block
Pushed code to my AWS lightsail instance
Triggered feed upload manually and verified that exception was thrown and persisted to Meta
After each exception was successfully logged I removed it from the code and pushed the updated logic to the AWS lightsail instance and triggered a feed upload manually again to verify the next exception
Did this for all added try/catch blocks
After all try/catch blocks were tested I pushed the code as it is in this PR now and triggered all feed uploads manually to verify that they were successful

…rsisted

…feed upload logic

github-actions · 2025-05-15T01:52:42Z

📦 Latest Plugin Build

Built at: 2025-05-15T01:52:42.224Z
Commit: 3ed2da2
Size: 1.1M

Download: Click here to download the plugin

To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact

github-actions · 2025-05-15T01:52:42Z

📦 Latest Plugin Build

Built at: 2025-05-15T01:52:42.224Z
Commit: 3ed2da2
Size: 1.1M

Download: Click here to download the plugin

To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact

github-actions · 2025-05-15T01:56:53Z

📦 Latest Plugin Build

Built at: 2025-05-15T01:56:52.877Z
Commit: f8d1f20
Size: 1.1M

Download: Click here to download the plugin

To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact

github-actions · 2025-05-15T01:56:53Z

📦 Latest Plugin Build

Built at: 2025-05-15T01:56:52.877Z
Commit: f8d1f20
Size: 1.1M

Download: Click here to download the plugin

To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact

facebook-github-bot · 2025-05-15T01:58:37Z

@nrostrow-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

github-actions · 2025-05-15T17:54:27Z

📦 Latest Plugin Build

Built at: 2025-05-15T17:54:27.292Z
Commit: df27614
Size: 1.1M

Download: Click here to download the plugin

To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact

github-actions · 2025-05-15T17:54:28Z

📦 Latest Plugin Build

Built at: 2025-05-15T17:54:27.292Z
Commit: df27614
Size: 1.1M

Download: Click here to download the plugin

To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact

facebook-github-bot · 2025-05-15T17:58:29Z

@nrostrow-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-05-15T19:30:32Z

@nrostrow-meta merged this pull request in d137bbf.

Summary: = 3.5.0 - 2025-05-28 = * Add - Create basic checkout permalink w/ products and coupon support by ajello-meta in #2887 * Add - Common Feed Upload Framework by Jmencab in #2875 * Fix - Fix bug where templates were not loading correctly by ajello-meta in #2915 * Tweak - Change MICE to use base site url instead of shop url by carterbuce in #2934 * Tweak - Improve custom checkout UI by ajello-meta in #2930 * Tweak - Make custom checkout UI mobile compatible by ajello-meta in #2942 * Fix - Update parsing for Checkout URL Product IDs by carterbuce in #2935 * Add - Implement dummy logging util by nealweiMeta in #2920 * Add - Setup cron job for batch logging with global message queue by nealweiMeta in #2924 * Add - Error log request api activate by nealweiMeta in #2933 * Add - Log locally with debug mode enabled by nealweiMeta in #2939 * Add - Ratings and reviews feed upload by nrostrow-meta in #2937 * Tweak - Feed upload skip logic and logging calls by nrostrow-meta in #2964 * Add - Add function to fetch feed upload instance by nrostrow-meta in #2970 * Tweak - Have feed uploads always use feed generator by nrostrow-meta in #2971 * Tweak - Trigger metadata feed uploads on CPI ID change (post onboarding) by nrostrow-meta in #2995 * Add - Shipping profile feed upload button by nrostrow-meta in #3140 * Add - Navigation menu feed upload logic by nrostrow-meta in #3159 * Fix - Fixing some fclose and logging gaps in the feed upload logic by nrostrow-meta in #3192 * Add - Enabling navigation menu feed upload and adding manual sync button by nrostrow-meta in #3223 * Add - Promotions feed upload by carterbuce in #2941 * Add - Plugin AJAX API Framework by sol-loup in #2928 * Tweak - Test Infrastructure Enhancement by sol-loup in #2944 * Add - Implement telemetry logs api by nealweiMeta in #2940 * Fix - Make error logging event configurable by nealweiMeta in #2954 * Add - Implement logging toggle by nealweiMeta in #2959 * Fix - auto products sync by nealweiMeta in #2978 * Tweak - Sync products with restriction by nealweiMeta in #2983 * Fix - Fix use_enhanced_onboarding for legacy connections by carterbuce in #2986 * Add - Create enhanced settings UI by ajello-meta in #2968 * Add - Create new troubleshooting drawer from legacy debug settings by ajello-meta in #2977 * Add - Add manual product and coupon sync buttons by ajello-meta in #2984 * Tweak - Make page title in enhanced settings static by ajello-meta in #2985 * Tweak - Align finalized content for logging toggle by nealweiMeta in #2992 * Tweak - Improve local log by nealweiMeta in #3009 * Fix - Fix free shipping coupon sync by carterbuce in #2993 * Tweak - Add logging for feed generation scheduling failure by carterbuce in #2994 * Tweak - Add logging in checkout for coupon code by ajello-meta in #2991 * Tweak - Clean up CSS in enhanced settings UI by ajello-meta in #2996 * Tweak - Remove the "Advertise" tab by ajello-meta in #3024 * Tweak - Sync "Usage Count" in Promos Feed by carterbuce in #3036 * Tweak - Disable mini_shops product capability for unsupported items by carterbuce in #3084 * Add - Add usage logging for enhanced settings tabs by ajello-meta in #3202 * Tweak - Remove UI of a checkbox that controls enablement of the new style feed generation by mshymon in #3056 * Fix - Fix linter errors for ./includes/fbutils.php files by ajello-meta in #3075 * Fix - Hotfix for Rollout Switches by vinkmeta in #3236 * Add - Opt out sync experience. by SayanPandey in #3220 * Fix - Added a transient flag to avoid flooding of product set api requests by vinkmeta in #3245 * Fix - Additional check for the opt-out banner by SayanPandey in #3259 * Fix - Bump up GraphAPI version to 21 by vahidkay-meta in #3219 * Fix - fix linter errors for ./class-wc-facebookcommerce.php by ajello-meta in #3255 * Fix - fix linter errors for ./facebook-commerce-events-tracker.php by ajello-meta in #3254 * Fix - fix linter errors for ./includes/Admin/Settings_Screens/Advertise.php by ajello-meta in #3237 * Fix - fix linter errors for ./includes/Admin/Settings_Screens/Product_Sync.php by ajello-meta in #3239 * Fix - fix function return typing for get_settings() by ajello-meta in #3257 * Tweak - Addition check for opt out by SayanPandey in #3259 * Tweak - Update the GraphAPI version to 21 by vahidkay-meta in #3219 * Fix - Enabled rollout switch only for plugin admins by vinkmeta in #3242 * Add - reset connection functionality by jczhuoMeta in #3262 * Fix - fixing the non static method called as static issue by SayanPandey in #3263 * Fix - Fix linter errors for ./facebook-commerce.php by ajello-meta in #3251 Pull Request resolved: #3264 Test Plan: Imported from GitHub, without a `Test Plan:` line. **!---- (auto-generated) DO NOT EDIT OR PUT ANYTHING AFTER THIS LINE ----!** MFTRunTestsScript Run / Test Suite: sa_checkout / Test Collection: bloks / Diff Version V7 https://internalfb.com/intern/testinfra/testrun/10414574226197703 MFTRunTestsScript Run / Test Suite: sa_checkout / Test Collection: www / Diff Version V7 https://internalfb.com/intern/testinfra/testrun/844425351364266 Reviewed By: vinkmeta, nrostrow-meta Differential Revision: D75569981 Pulled By: carterbuce fbshipit-source-id: 11bb39a9d66dfcbc80af413466feef0792d27ce4

nrostrow-meta added 5 commits May 14, 2025 16:14

Adding try/catch blocks to file writing logic to ensure errors are pe…

4b540cd

…rsisted

Making sure that fclose is being called everywhere that fopen is for …

6059c9d

…feed upload logic

Fixing spacing

bf9260b

Removing testing exceptions

630ea80

Reverting some local testing changes

28b45d0

facebook-github-bot added the CLA Signed label May 15, 2025

Addressing PHPCS errors

518411e

nrostrow-meta added 2 commits May 15, 2025 10:48

Merge branch 'main' into feed_upload_logging_update

2e25354

Adding @ back to fpassthru

a26503e

facebook-github-bot closed this in d137bbf May 15, 2025

facebook-github-bot added the Merged label May 15, 2025

This was referenced May 20, 2025

activate simplified shops #3221

Closed

activate simplified shops2 #3222

Closed

fix duplicate product set tool title #3247

Open

carterbuce mentioned this pull request May 29, 2025

Release/3.5.0 #3264

Closed

tzahgr mentioned this pull request Jun 4, 2025

Release/3.5.0 #3293

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feed upload logging update#3192

Feed upload logging update#3192
nrostrow-meta wants to merge 8 commits intomainfrom
feed_upload_logging_update

nrostrow-meta commented May 15, 2025

Uh oh!

github-actions bot commented May 15, 2025

Uh oh!

github-actions bot commented May 15, 2025

Uh oh!

github-actions bot commented May 15, 2025

Uh oh!

github-actions bot commented May 15, 2025

Uh oh!

facebook-github-bot commented May 15, 2025

Uh oh!

github-actions bot commented May 15, 2025

Uh oh!

github-actions bot commented May 15, 2025

Uh oh!

facebook-github-bot commented May 15, 2025

Uh oh!

facebook-github-bot commented May 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

nrostrow-meta commented May 15, 2025

Description

Type of change

Checklist

Changelog entry

Test Plan

Uh oh!

github-actions bot commented May 15, 2025

📦 Latest Plugin Build

Uh oh!

github-actions bot commented May 15, 2025

📦 Latest Plugin Build

Uh oh!

github-actions bot commented May 15, 2025

📦 Latest Plugin Build

Uh oh!

github-actions bot commented May 15, 2025

📦 Latest Plugin Build

Uh oh!

facebook-github-bot commented May 15, 2025

Uh oh!

github-actions bot commented May 15, 2025

📦 Latest Plugin Build

Uh oh!

github-actions bot commented May 15, 2025

📦 Latest Plugin Build

Uh oh!

facebook-github-bot commented May 15, 2025

Uh oh!

facebook-github-bot commented May 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants