Fix use_enhanced_onboarding for legacy connections

[carterbuce]

Description

If a user has connected to Meta using use_enhanced_onboarding=false, they should continue to see the old settings screens until they've disconnected. This currently doesn't see to be the case, as I was encountering the "Shops" tab when turning use_enhanced_onboarding to true while already connected.

This PR unifies our two separate use_enhanced_onboarding methods into a single one.

Unfortunately, there isn't a sufficient mocking framework available to override the global facebook_for_woocommerce() function in tests. Therefore this PR also updates a few of the classes to take in the plugin as a parameter in the constructor to allow for dependency injection.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots

Please provide screenshots or snapshots of the system/state both before and after implementing the changes, if appropriate

Before

After

With legacy connection:

After disconnecting legacy connection:

After reconnecting to Meta:

Test instructions

1. Connect to Meta
2. Set the final return statement in use_enhanced_onboarding to true
3. Observe the settings screen did not change
4. Disconnect shop
5. Observe enhanced onboarding flow is now present

Checklist

• I followed general Pull Request best practices. Meta employees to follow this wiki
• I have commented my code, particularly in hard-to-understand areas
• I have added tests and all the new and existing unit tests pass locally with my changes
• I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.

Changelog entry

Fix legacy connection view when use_enhanced_onboarding is set to true

[facebook-github-bot]

@carterbuce has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@carterbuce has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@carterbuce has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@carterbuce merged this pull request in 597b5e9.