Trigger feed uploads on onboarding completion

[nrostrow-meta]

Description

This PR builds on #2983 to trigger metadata feed uploads to run if CPI ID is updated (will have metadata feed uploads triggered on onboarding completion).

To accomplish this a new run_all_feed_uploads() function was added to FeedManager to call to trigger all of the feed uploads to run.

The logic of handle_update() was updated a little bit as well. We only want to trigger catalog sync if catalog ID is being updated and only trigger the metadata feed uploads if CPI ID is being updated. Previously we were checking if these values were being updated and then triggering the sync/feed uploads before calling update_settings(). The product sync/feed uploads logic depends on the values that are being updated though. So we actually need to be checking to see if the values are being updated before calling update_settings() but then we shouldn't actually trigger the sync/feed uploads until after calling update_settings().

I also went through and fixed several lint warnings I found in facebook-commerce.php and Handler.php

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Test instructions

1. Locally changed maybe_trigger_feed_uploads() to be public instead of private (so it could be called from WP Console) and then pushed the code to my lightsail instance
2. Used WP Console to run some code to manually test the new logic
3. Verified that when $should_trigger_metadata_feed_uploads is true that the call to maybe_trigger_feed_uploads() triggers the metadata feed uploads
   
   
4. Verified that when $should_trigger_metadata_feed_uploads is false that the call to maybe_trigger_feed_uploads() doesn't trigger the metadata feed uploads (no logs on Meta side for calls to GraphCommercePartnerIntegrationFileUpdatePost)
   

Checklist

• I followed general Pull Request best practices. Meta employees to follow this wiki
• I have commented my code, particularly in hard-to-understand areas
• I have added tests and all the new and existing unit tests pass locally with my changes
• I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.

Changelog entry

Triggering metadata feed uploads to run on CPI ID update

[facebook-github-bot]

@nrostrow-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@nrostrow-meta merged this pull request in 0fe6d57.