Closed
Conversation
Contributor
|
@sol-loup has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mradmeta
approved these changes
Mar 25, 2025
vahidkay-meta
approved these changes
Mar 25, 2025
Contributor
SayanPandey
pushed a commit
to SayanPandey/facebook-for-woocommerce
that referenced
this pull request
Apr 1, 2025
Summary: ## Description A term used in our code was not correct, as this does not transmit any data of the kind implied by the term. This is purely an error logging and simple logging system. ### Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Screenshots Please provide screenshots or snapshots of the system/state both before and after implementing the changes, if appropriate ### Before ### After ## Test instructions Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. ## Checklist - [ ] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests and all the new and existing unit tests pass locally with my changes - [ ] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. ## Changelog entry One liner entry to be surfaced in changelog.txt Pull Request resolved: facebook#2966 Test Plan: # Testing Completed: 1. Added logging statement to pageload 2. Logged FB API response and Request values. 3. Confirmed API is being hit (with correct API Token) when logger is called [26-Mar-2025 00:01:44 UTC] Facebook API Request: Array ( [event] => test_log [event_type] => page_load [extra_data] => Array ( [page] => connection_settings [timestamp] => 1742947304 ) ) [26-Mar-2025 00:01:44 UTC] Facebook API Response: WooCommerce\Facebook\API\MetaLog\Response Object ( [raw_response_json:protected] => {"success":true} [response_data] => Array ( [success] => 1 ) ) Reviewed By: nrostrow-meta, nealweiMeta Differential Revision: D71819581 Pulled By: sol-loup fbshipit-source-id: 668ea86fcf6ad8e3ce902e59f3cee56b59149065
This was referenced Apr 10, 2025
Closed
Closed
mradmeta
pushed a commit
that referenced
this pull request
Apr 14, 2025
Summary: ## Description A term used in our code was not correct, as this does not transmit any data of the kind implied by the term. This is purely an error logging and simple logging system. ### Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Screenshots Please provide screenshots or snapshots of the system/state both before and after implementing the changes, if appropriate ### Before ### After ## Test instructions Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. ## Checklist - [ ] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests and all the new and existing unit tests pass locally with my changes - [ ] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. ## Changelog entry One liner entry to be surfaced in changelog.txt Pull Request resolved: #2966 Test Plan: # Testing Completed: 1. Added logging statement to pageload 2. Logged FB API response and Request values. 3. Confirmed API is being hit (with correct API Token) when logger is called [26-Mar-2025 00:01:44 UTC] Facebook API Request: Array ( [event] => test_log [event_type] => page_load [extra_data] => Array ( [page] => connection_settings [timestamp] => 1742947304 ) ) [26-Mar-2025 00:01:44 UTC] Facebook API Response: WooCommerce\Facebook\API\MetaLog\Response Object ( [raw_response_json:protected] => {"success":true} [response_data] => Array ( [success] => 1 ) ) Reviewed By: nrostrow-meta, nealweiMeta Differential Revision: D71819581 Pulled By: sol-loup fbshipit-source-id: 668ea86fcf6ad8e3ce902e59f3cee56b59149065
This was referenced Apr 18, 2025
This was referenced May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A term used in our code was not correct, as this does not transmit any data of the kind implied by the term. This is purely an error logging and simple logging system.
Type of change
Please delete options that are not relevant.
Screenshots
Please provide screenshots or snapshots of the system/state both before and after implementing the changes, if appropriate
Before
After
Test instructions
Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration.
Checklist
Changelog entry
One liner entry to be surfaced in changelog.txt