Closed
Conversation
Contributor
|
@sol-loup has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses code quality issues in the AdminNoticeHandler.php file by fixing PHPCS warnings and errors. The changes focus on code style consistency, proper syntax formatting, and adherence to WordPress coding standards.
Type of change
Syntax change (non-breaking change which fixes code modularity, linting or phpcs issues)
Checklist
[x] I have confirmed that my changes do not introduce any new PHPCS warnings or errors.
[x] I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors.
[x] I followed general Pull Request best practices.
Changelog entry
Fixed PHPCS issues in AdminNoticeHandler class for improved code quality and standard compliance.
Test Plan
Verified the plugin works properly after these changes
Confirmed that notices still display and function correctly
Ran PHPCS to ensure no new issues were introduced
Before
Code contained PHPCS violations including:
Inconsistent spacing in code blocks and parameters
Improper variable declaration order (static private instead of private static)
Inconsistent spacing in arrays and function calls
PHPCS ignore directive at file beginning
Incorrect logical operator (or instead of standard ||)
After
Properly formatted code with consistent spacing
Corrected variable declaration order
Properly formatted docblocks with correct parameter spacing
Removed unnecessary PHPCS ignore directive
Standardized logical operator usage