Skip to content

[LINTFIX] Fixes for AdminNoticeHandler.php#3131

Closed
sol-loup wants to merge 1 commit intomainfrom
sollipse-lintfixes-5-2-A
Closed

[LINTFIX] Fixes for AdminNoticeHandler.php#3131
sol-loup wants to merge 1 commit intomainfrom
sollipse-lintfixes-5-2-A

Conversation

@sol-loup
Copy link
Copy Markdown
Contributor

@sol-loup sol-loup commented May 2, 2025

Description

This PR addresses code quality issues in the AdminNoticeHandler.php file by fixing PHPCS warnings and errors. The changes focus on code style consistency, proper syntax formatting, and adherence to WordPress coding standards.
Type of change
Syntax change (non-breaking change which fixes code modularity, linting or phpcs issues)

Checklist

[x] I have confirmed that my changes do not introduce any new PHPCS warnings or errors.
[x] I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors.
[x] I followed general Pull Request best practices.

Changelog entry

Fixed PHPCS issues in AdminNoticeHandler class for improved code quality and standard compliance.
Test Plan
Verified the plugin works properly after these changes
Confirmed that notices still display and function correctly
Ran PHPCS to ensure no new issues were introduced

Before

Code contained PHPCS violations including:
Inconsistent spacing in code blocks and parameters
Improper variable declaration order (static private instead of private static)
Inconsistent spacing in arrays and function calls
PHPCS ignore directive at file beginning
Incorrect logical operator (or instead of standard ||)

After

Properly formatted code with consistent spacing
Corrected variable declaration order
Properly formatted docblocks with correct parameter spacing
Removed unnecessary PHPCS ignore directive
Standardized logical operator usage

@sol-loup sol-loup changed the title sollipse lintfixes 5 2 A [LINTFIX] Fixes for AdminNoticeHandler.php May 2, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@sol-loup has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@sol-loup merged this pull request in 381057e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants