Fixing namespacing issue causing some tests to be skipped

[sol-loup]

Summary

This PR addresses a PSR-4 autoloading compliance issue that prevented several PHPUnit tests from being discovered and executed. When running PHPUnit, errors like Class ... located in ... does not comply with psr-4 autoloading standard. Skipping. were reported for multiple test files.

Root Cause:

The issue stemmed from a mismatch between the namespace declarations within the test files and the PSR-4 autoloading configuration defined in composer.json. Specifically:

1. The composer.json file maps the base namespace WooCommerce\Facebook\Tests\ to the directory tests/Unit/.

     "autoload-dev": {
       "psr-4": {
         "WooCommerce\\Facebook\\Tests\\": "tests/Unit"
       }
     }

2. According to PSR-4, any subsequent parts of a namespace must correspond directly to the subdirectory structure under the base path (tests/Unit/).
3. Several test files incorrectly included Unit as part of their namespace (e.g., namespace WooCommerce\Facebook\Tests\Unit\Admin\Settings;) while residing in paths like tests/Unit/Admin/Settings/.
4. This caused the autoloader to look for the class file in an incorrect, nested path (e.g., tests/Unit/Unit/Admin/Settings/ConnectionTest.php) instead of the actual location (tests/Unit/Admin/Settings/ConnectionTest.php), leading to the "does not comply" error.
5. In some cases, minor discrepancies in directory names (e.g., API\Plugin in the namespace vs. Api\REST in the path) also contributed to the problem.

How changes were detected and fixed

Thankfully, running composer dump-autoload -o was sufficient to uncover all the PSR skipped tests:
Class WooCommerce\Facebook\Tests\Unit\Framework\Utilities\AsyncRequestTest located in ./tests/Unit/Framework/Utilities/AsyncRequestTest.php does not comply with psr-4 autoloading standard. Skipping.
Class WooCommerce\Facebook\Tests\Unit\ConnectionTest located in ./tests/Unit/Admin/Settings/ConnectionTest.php does not comply with psr-4 autoloading standard. Skipping.
Class WooCommerce\Facebook\Tests\Unit\Admin\Settings\ShopsTest located in ./tests/Unit/Admin/Settings/ShopsTest.php does not comply with psr-4 autoloading standard. Skipping.
Class WooCommerce\Facebook\Tests\Unit\Admin\Settings_Screens\ConnectionTest located in ./tests/Unit/Admin/Settings_Screens/ConnectionTest.php does not comply with psr-4 autoloading standard. Skipping.
Class WooCommerce\Facebook\Tests\Unit\Admin\Settings_Screens\ShopsTest located in ./tests/Unit/Admin/Settings_Screens/ShopsTest.php does not comply with psr-4 autoloading standard. Skipping.
Class WooCommerce\Facebook\Tests\Unit\API\Plugin\RestAPITest located in ./tests/Unit/Api/REST/RestAPITest.php does not comply with psr-4 autoloading standard. Skipping.
Class WooCommerce\Facebook\Tests\Unit\Handlers\MetaExtensionTest located in ./tests/Unit/Handlers/MetaExtensionTest.php does not comply with psr-4 autoloading standard. Skipping.

Changes:

The namespace declarations in the affected test files have been modified to accurately reflect their directory structure relative to the tests/Unit/ base path defined in composer.json. This typically involved removing the redundant Unit segment from the namespace or correcting other segments to match the actual folder names (e.g., changing API\Plugin to Api\REST).

These changes ensure that the class namespaces correctly map to their file locations according to the PSR-4 standard, allowing Composer's autoloader and PHPUnit to find and execute the tests properly.

Test Plan

1. Checked out the branch containing these changes.
2. Ran composer dump-autoload to ensure the autoloader cache was updated.
3. Executed the PHPUnit test suite using the standard command (vendor/bin/phpunit or composer test-unit).
4. Result: PHPUnit completed its run successfully, executing 286 tests without the previous PSR-4 autoloading errors.

[facebook-github-bot]

@sol-loup has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@sol-loup has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@sol-loup merged this pull request in 30b28f4.