Skip to content

Comments

Develop -> Master#2721

Merged
mslipper merged 28 commits intomasterfrom
develop
Jun 8, 2022
Merged

Develop -> Master#2721
mslipper merged 28 commits intomasterfrom
develop

Conversation

@mslipper
Copy link
Collaborator

@mslipper mslipper commented Jun 8, 2022

mslipper and others added 28 commits June 6, 2022 08:52
According to Mergify support this should prevent the looping we've seen.
See the README for an overview.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* op-node: Remove multi L2 Engine Option

This stops the rollup node from driving multiple L2 engines at once.
This makes node lifecycle management easier.
It also has associated command line and testing changes.

* PR Fixups

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Updates and standardizes the style for the L1 contracts. Adds a few
comments where things were missing.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* feat(ctp): minor Drippie client-side tweaks

Tweaks Drippie to make the client-side a bit simpler. Adds a separate
function "executable" that can be queried to see if a given drip is
currently executable. Updates events so that the name will be properly
emitted but can still be indexed.

* feat: introduce the drippie-mon service

Introduces drippie-mon, a basic service for monitoring Drippie
deployments. drippie-mon will increment a metric whenever a drip is
currently executable. Clients of drippie-mon can watch for this metric
to see if a drip has been executable for a while but has not yet been
executed.
…tches (#2705)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* contracts-bedrock: update forge-std

* contracts-bedrock: update forge-std

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Introduces a simple middleware contract for withdrawing funds from
Teleportr.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* contracts: optimize `L1Block.setL1BlockValues`

The amount of gas required to update the
L1 block values can be reduced by ~5000 gas by tightly
packing the `uint64`s into a single storage slot.
This is important because there will be a single
transaction at the beginning of each block that will
be updating these values. ~100 gas is saved by using
yul instead of straight solidity. I don't feel like the
yul is particularly difficult to read in this context,
and saving 100 gas per block will add up to a lot over
the history of the chain. This logic is covered by foundry
fuzzing.

* op-bindings: regenerate
* package: contracts-governance

* contracts-governance: update deps

kelvin magic touch

* contracts-governance: fix tsconfig

* deps: more fixes

* ci: add contracts-governance tests

* ops: install contracts-governance

* Create light-parrots-yell.md

* contracts-governance: delete nvmrc

* contracts-governance: package.json cleanup

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This fixes a bug where the infura backend would be labeled offline because it
returns an unexpected JSON-RPC response. Unexpected, but well-formed,
JSON-RPC response are handled specially. Such errors are surfaced up to
the backend proxier so failover still occurs.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Redeploy to Goerli

* yarn autogen:markdown

* Added changeset

* Added new goerli genesis

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Fixes a panic in the websocket proxyd logic. Normally, the `clientPump` and `backendPump` methods in `WSProxier` send data in one direction. However, when the client sends an invalid RPC, the `clientPump` will send a response _directly to the client_ in order to avoid unnecessary roundtrips to the backend. This could be interleaved with concurrent writes to the client's WS in `backendPump`, and would cause a panic in the WS library.

To test this, this PR includes a dedicated integration test that reliably triggers the issue. In addition, this PR adds additional testing for WS functionality.
BaseServiceV2 will expose internal options (loop interval, metrics port,
etc) as environment variables or command line options.
* specs: Update executePayloadV1 to newPayloadV1

Just updating the name in the specs. This has already been changed
in the code.

* specs: Deposits -> Withdrawals spec clarification

Wording was incorrect.

* specs: Remove unnecessary cast

The casts from bytes32 -> uint256 -> bytes32 is not needed.

* specs: no alias on withdrawals

* fix lint

* specs: fix parentheses

Co-authored-by: Diederik Loerakker <proto@protolambda.com>

Co-authored-by: Maurelian <maurelian@protonmail.ch>
Co-authored-by: Diederik Loerakker <proto@protolambda.com>
This was previously missing.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Re-deploys the RetroReceiver with a new default owner called the
Dedicated Deterministic Deployer address. When deploying authenticated
smart contracts deterministically to the same address on many chains,
it's necessary to have a known static owner that then transfers
ownership to the final owner after deployment (which can be different on
every chain). This PR re-deploys the original contract with that new
default owner, the DDD.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2022

🦋 Changeset detected

Latest commit: f96e73b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@eth-optimism/proxyd Patch
@eth-optimism/contracts-periphery Patch
@eth-optimism/contracts Patch
@eth-optimism/contracts-governance Patch
@eth-optimism/contracts-bedrock Patch
@eth-optimism/drippie-mon Minor
@eth-optimism/common-ts Patch
@eth-optimism/data-transport-layer Patch
@eth-optimism/sdk Patch
@eth-optimism/message-relayer Patch
@eth-optimism/replica-healthcheck Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mslipper mslipper merged commit ad4440f into master Jun 8, 2022
@github-actions github-actions bot added 2-reviewers A-op-bindings Area: op-bindings A-ops Area: ops labels Jun 8, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
Removes redundancy in typos config and avoids checking
superchain-registry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-op-bindings Area: op-bindings A-ops Area: ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants