op-node: Remove multi L2 Engine Option#2699
Merged
mergify[bot] merged 3 commits intodevelopfrom Jun 7, 2022
Merged
Conversation
This stops the rollup node from driving multiple L2 engines at once. This makes node lifecycle management easier. It also has associated command line and testing changes.
trianglesphere
requested review from
mslipper and
protolambda
and removed request for
protolambda
mslipper
approved these changes
Jun 7, 2022
Collaborator
mslipper
left a comment
mslipper
left a comment
There was a problem hiding this comment.
I think this is much simpler. Thanks.
protolambda
reviewed
Jun 7, 2022
|
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
Closes #2662 The `ReorgTask` already contains the logic for verifying the consistency. I'm reusing it at startup by calling the `handle_l1_reorg` when initializing the l1 watcher.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This stops the rollup node from driving multiple L2 engines at once.
This makes node lifecycle management easier.
It also has associated command line and testing changes.
Additional context
I tested the devnet locally and I don't believe that I need to make any changes there.
The flag names are actually the same, so as long as no one was passing in multiple
addresses or jwtsecrets, nothing changes.
Metadata