Skip to content

feat(ctp): update style for L1 contracts#2704

Merged
mergify[bot] merged 2 commits intodevelopfrom
sc/ctb-l1-style
Jun 7, 2022
Merged

feat(ctp): update style for L1 contracts#2704
mergify[bot] merged 2 commits intodevelopfrom
sc/ctb-l1-style

Conversation

@smartcontracts
Copy link
Contributor

Description
Updates and standardizes the style for the L1 contracts. Adds a few
comments where things were missing.

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2022

🦋 Changeset detected

Latest commit: 40bb51f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/contracts-bedrock Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mergify mergify bot requested review from Inphi and tuxcanfly June 7, 2022 00:59
Updates and standardizes the style for the L1 contracts. Adds a few
comments where things were missing.
@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jun 7, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2022

Merge failed. Please see automated check logs for more details.

@tynes
Copy link
Contributor

tynes commented Jun 7, 2022

Flakey test?

#27 33.80 Error HH503: Couldn't download compiler version 0.8.9. Checksum verification failed. Please check your connection.
#27 33.80 HardhatError: HH503: Couldn't download compiler version 0.8.9. Checksum verification failed. Please check your connection.
#27 33.80     at CompilerDownloader.verifyCompiler (/opt/optimism/node_modules/hardhat/src/internal/solidity/compiler/downloader.ts:97:13)
#27 33.80     at async CompilerDownloader.getDownloadedCompilerPath (/opt/optimism/node_modules/hardhat/src/internal/solidity/compiler/downloader.ts:117:7)
#27 33.80     at async SimpleTaskDefinition.action (/opt/optimism/node_modules/hardhat/src/builtin-tasks/compile.ts:606:11)
#27 33.80     at async Environment._runTaskDefinition (/opt/optimism/node_modules/hardhat/src/internal/core/runtime-environment.ts:219:14)
#27 33.80     at async Environment.run (/opt/optimism/node_modules/hardhat/src/internal/core/runtime-environment.ts:131:14)
#27 33.80     at async SimpleTaskDefinition.action (/opt/optimism/node_modules/hardhat/src/builtin-tasks/compile.ts:423:9)
#27 33.80     at async Environment._runTaskDefinition (/opt/optimism/node_modules/hardhat/src/internal/core/runtime-environment.ts:219:14)
#27 33.80     at async Environment.run (/opt/optimism/node_modules/hardhat/src/internal/core/runtime-environment.ts:131:14)
#27 33.80     at async SimpleTaskDefinition.action (/opt/optimism/node_modules/hardhat/src/builtin-tasks/compile.ts:1358:63)
#27 33.80     at async Environment._runTaskDefinition (/opt/optimism/node_modules/hardhat/src/internal/core/runtime-environment.ts:219:14

@smartcontracts
Copy link
Contributor Author

Flakey test?

#27 33.80 Error HH503: Couldn't download compiler version 0.8.9. Checksum verification failed. Please check your connection.
#27 33.80 HardhatError: HH503: Couldn't download compiler version 0.8.9. Checksum verification failed. Please check your connection.
#27 33.80     at CompilerDownloader.verifyCompiler (/opt/optimism/node_modules/hardhat/src/internal/solidity/compiler/downloader.ts:97:13)
#27 33.80     at async CompilerDownloader.getDownloadedCompilerPath (/opt/optimism/node_modules/hardhat/src/internal/solidity/compiler/downloader.ts:117:7)
#27 33.80     at async SimpleTaskDefinition.action (/opt/optimism/node_modules/hardhat/src/builtin-tasks/compile.ts:606:11)
#27 33.80     at async Environment._runTaskDefinition (/opt/optimism/node_modules/hardhat/src/internal/core/runtime-environment.ts:219:14)
#27 33.80     at async Environment.run (/opt/optimism/node_modules/hardhat/src/internal/core/runtime-environment.ts:131:14)
#27 33.80     at async SimpleTaskDefinition.action (/opt/optimism/node_modules/hardhat/src/builtin-tasks/compile.ts:423:9)
#27 33.80     at async Environment._runTaskDefinition (/opt/optimism/node_modules/hardhat/src/internal/core/runtime-environment.ts:219:14)
#27 33.80     at async Environment.run (/opt/optimism/node_modules/hardhat/src/internal/core/runtime-environment.ts:131:14)
#27 33.80     at async SimpleTaskDefinition.action (/opt/optimism/node_modules/hardhat/src/builtin-tasks/compile.ts:1358:63)
#27 33.80     at async Environment._runTaskDefinition (/opt/optimism/node_modules/hardhat/src/internal/core/runtime-environment.ts:219:14

I've been seeing this recently, idk what's going on

@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit c258acd into develop Jun 7, 2022
@mergify mergify bot deleted the sc/ctb-l1-style branch June 7, 2022 16:36
@mergify mergify bot removed the on-merge-train label Jun 7, 2022
This was referenced Jun 8, 2022
theochap added a commit that referenced this pull request Dec 10, 2025
## Description

Fixes CI. The error was that in docker the home directory doesn't exist,
so the default bootstore cannot be opened or created
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants