state-surgery: Add state surgery#2655
state-surgery: Add state surgery#2655mergify[bot] merged 2 commits intoethereum-optimism:developfrom
Conversation
|
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
485aa20 to
56c9f2d
Compare
trianglesphere
left a comment
There was a problem hiding this comment.
Generally looks good. It's missing some integrations with outer level makefiles / CI & testing, but I'm also not sure what level of rigor / long term support we plan for this package.
Also, if 2hrs is too long, running a CPU profile w/ pprof can often identify simple things that make a big difference.
a494f60 to
ffcab56
Compare
See the README for an overview.
ffcab56 to
586e476
Compare
trianglesphere
left a comment
There was a problem hiding this comment.
LGTM.
Just an FYI for when running it, configuring the handles + cache is tricky. The default handles + cache looks good. At least on Macs, the handle limit is pretty low (will vary on linux boxes). Geth also limits the cache to 1/3 of system memory b/c apparently go's gc allows garbage to get up to 2x the typical usage prior to a GC sweep.
|
This PR has been added to the merge queue, and will be merged soon. |
|
@mslipper added merfigy-ignore b/c failing tests. They seem unrelated, but probably need to be re-ran. |
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
See the README for an overview.