Skip to content

Comments

state-surgery: Add state surgery#2655

Merged
mergify[bot] merged 2 commits intoethereum-optimism:developfrom
mslipper:feat/state-surgery
Jun 7, 2022
Merged

state-surgery: Add state surgery#2655
mergify[bot] merged 2 commits intoethereum-optimism:developfrom
mslipper:feat/state-surgery

Conversation

@mslipper
Copy link
Collaborator

@mslipper mslipper commented Jun 2, 2022

See the README for an overview.

@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2022

⚠️ No Changeset found

Latest commit: 11bc952

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mslipper mslipper force-pushed the feat/state-surgery branch 2 times, most recently from 485aa20 to 56c9f2d Compare June 2, 2022 10:29
@mslipper mslipper changed the title state-surgery: Add state sturgery state-surgery: Add state surgery Jun 2, 2022
@trianglesphere trianglesphere self-requested a review June 3, 2022 17:21
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. It's missing some integrations with outer level makefiles / CI & testing, but I'm also not sure what level of rigor / long term support we plan for this package.

Also, if 2hrs is too long, running a CPU profile w/ pprof can often identify simple things that make a big difference.

@mslipper mslipper force-pushed the feat/state-surgery branch 2 times, most recently from a494f60 to ffcab56 Compare June 6, 2022 01:54
See the README for an overview.
@mslipper mslipper force-pushed the feat/state-surgery branch from ffcab56 to 586e476 Compare June 6, 2022 01:54
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just an FYI for when running it, configuring the handles + cache is tricky. The default handles + cache looks good. At least on Macs, the handle limit is pretty low (will vary on linux boxes). Geth also limits the cache to 1/3 of system memory b/c apparently go's gc allows garbage to get up to 2x the typical usage prior to a GC sweep.

@mergify
Copy link
Contributor

mergify bot commented Jun 6, 2022

This PR has been added to the merge queue, and will be merged soon.

@trianglesphere
Copy link
Contributor

@mslipper added merfigy-ignore b/c failing tests. They seem unrelated, but probably need to be re-ran.

@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit ac062f8 into ethereum-optimism:develop Jun 7, 2022
@mergify mergify bot removed the on-merge-train label Jun 7, 2022
This was referenced Jun 8, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants