Skip to content

Comments

feat(ctp): introduce TeleportrWithdrawer#2709

Merged
mergify[bot] merged 2 commits intodevelopfrom
sc/teleportr-withdrawer
Jun 8, 2022
Merged

feat(ctp): introduce TeleportrWithdrawer#2709
mergify[bot] merged 2 commits intodevelopfrom
sc/teleportr-withdrawer

Conversation

@smartcontracts
Copy link
Contributor

Description
Introduces a simple middleware contract for withdrawing funds from
Teleportr.

Introduces a simple middleware contract for withdrawing funds from
Teleportr.
@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2022

🦋 Changeset detected

Latest commit: d350a83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@eth-optimism/contracts-periphery Patch
@eth-optimism/drippie-mon Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 2-reviewers A-op-bindings Area: op-bindings labels Jun 7, 2022
@mergify mergify bot requested review from Inphi and mslipper June 7, 2022 21:04
Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I think it makes sense to move teleporter into this package as well

@smartcontracts
Copy link
Contributor Author

Looks good to me, I think it makes sense to move teleporter into this package as well

Agreed

@mergify mergify bot requested a review from Inphi June 7, 2022 21:54
@mslipper
Copy link
Collaborator

mslipper commented Jun 8, 2022

If TeleportrDeposit is owned by the Withdrawer, is it possible to set TeleportrDeposit's ownership to a different address?

@mslipper
Copy link
Collaborator

mslipper commented Jun 8, 2022

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2022

refresh

✅ Pull request refreshed

@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 9142adc into develop Jun 8, 2022
@mergify mergify bot deleted the sc/teleportr-withdrawer branch June 8, 2022 00:49
@mergify mergify bot removed the on-merge-train label Jun 8, 2022
This was referenced Jun 8, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
Adds comprehensive metrics to the block validation logic in Kona's P2P
gossip module to enable monitoring and alerting capabilities. The
implementation tracks validation attempts, success/failure rates with
detailed error categorization, validation duration, and block version
distribution.

Closes #2362

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-op-bindings Area: op-bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants