Conversation
|
There was a problem hiding this comment.
I cross referenced this list with the contracts (after #2580) and I think I'm only seeing one missing contract in the other PR. EDIT: I found the OptimismMintableTokenFactory in a different folder.
At this point it's one question about a name / deprecation.
One other thing that got dropped is that we need to pull these addresses into go and make sure that we use them in the right places in our test systems (we are currently using self consistently wrong addresses which is why it works now). - this is not a blocker for this PR.
|
@tynes are you planning to push this forwards? |
I fixed the issue noted above, there are other places that the contract is named incorrectly but I think we should do that in a follow up PR |
|
I'd also like to remove all references to the interfaces in this eventually and instead link to an |
trianglesphere
left a comment
trianglesphere
left a comment
There was a problem hiding this comment.
lgtm
I'm not sure where we should record the follow ups (ensure L1 Block is the contract name & reminder to upgrade to interfaces).
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
## Overview Adds the confirmation-delayed provider for the sequencer's L1 origin selector. This provider holds a reference to the L1 chain's head, and delays any block-by-number requests by a configurable amount. This prevents the sequencer from selecting an origin too close to the tip of the chain, resulting in fewer L1 origin selections that are reorganized out. closes #2401
3 participants
Description
Add predeploys spec. These need to be upgraded in a backwards compatible way
Replaces ethereum-optimism/optimistic-specs#379