Skip to content

feat: introduce the drippie-mon service #2687

Merged
mergify[bot] merged 2 commits intodevelopfrom
sc/drippie-mon
Jun 7, 2022
Merged

feat: introduce the drippie-mon service #2687
mergify[bot] merged 2 commits intodevelopfrom
sc/drippie-mon

Conversation

@smartcontracts
Copy link
Contributor

Description
Introduces drippie-mon, a basic service for monitoring Drippie
deployments. drippie-mon will increment a metric whenever a drip is
currently executable. Clients of drippie-mon can watch for this metric
to see if a drip has been executable for a while but has not yet been
executed.

@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2022

🦋 Changeset detected

Latest commit: a7719b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@eth-optimism/contracts-periphery Patch
@eth-optimism/drippie-mon Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 2-reviewers A-op-bindings Area: op-bindings labels Jun 5, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@smartcontracts smartcontracts force-pushed the sc/drippie-mon branch 4 times, most recently from e076a1d to 8fb6d00 Compare June 5, 2022 20:34
@smartcontracts smartcontracts marked this pull request as ready for review June 7, 2022 19:01
@mslipper mslipper self-requested a review June 7, 2022 19:01
Tweaks Drippie to make the client-side a bit simpler. Adds a separate
function "executable" that can be queried to see if a given drip is
currently executable. Updates events so that the name will be properly
emitted but can still be indexed.
Copy link
Collaborator

@mslipper mslipper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

Introduces drippie-mon, a basic service for monitoring Drippie
deployments. drippie-mon will increment a metric whenever a drip is
currently executable. Clients of drippie-mon can watch for this metric
to see if a drip has been executable for a while but has not yet been
executed.
@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 982cb98 into develop Jun 7, 2022
@mergify mergify bot deleted the sc/drippie-mon branch June 7, 2022 19:46
@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jun 7, 2022
This was referenced Jun 8, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
fix function name

---------

Signed-off-by: hongmengning <hongmengning@outlook.com>
Co-authored-by: clabby <ben@clab.by>
Co-authored-by: Emilia Hane <emiliaha95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-op-bindings Area: op-bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants