Skip to content

contributing: note how to install foundry#2710

Merged
mergify[bot] merged 2 commits intodevelopfrom
fix/install-deps
Jun 8, 2022
Merged

contributing: note how to install foundry#2710
mergify[bot] merged 2 commits intodevelopfrom
fix/install-deps

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Jun 7, 2022

Description
Add directions on how to install foundry to the contributing doc

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: c951b7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot requested review from mslipper and tuxcanfly June 7, 2022 21:09
@smartcontracts
Copy link
Contributor

smartcontracts commented Jun 7, 2022 •
edited
Loading

Pls also add to dependencies: https://github.com/ethereum-optimism/optimism/blob/develop/CONTRIBUTING.md#dependencies

@tynes tynes force-pushed the fix/install-deps branch from ebf8a7c to e759e0c Compare June 7, 2022 21:41
@tynes
Copy link
Contributor Author

tynes commented Jun 7, 2022

Pls also add to dependencies: https://github.com/ethereum-optimism/optimism/blob/develop/CONTRIBUTING.md#dependencies

addressed, good catch

smartcontracts
smartcontracts approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ty

@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 198e8bf into develop Jun 8, 2022
@mergify mergify bot deleted the fix/install-deps branch June 8, 2022 01:05
@mergify mergify bot removed the on-merge-train label Jun 8, 2022
This was referenced Jun 8, 2022
Merged
Merged
theochap pushed a commit that referenced this pull request Dec 10, 2025
@Fibonacci747
fix: Add missing colon in error message (#2710)
3405acc 
- Add missing colon in error message for RPC receipts conversion in
chain_provider.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smartcontracts smartcontracts smartcontracts approved these changes

@tuxcanfly tuxcanfly Awaiting requested review from tuxcanfly

+1 more reviewer

@mslipper mslipper mslipper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tynes @smartcontracts @mslipper