Bedrock - temporary batch-builder reorg fix - don't omit empty batches#2705
Bedrock - temporary batch-builder reorg fix - don't omit empty batches#2705mergify[bot] merged 2 commits intodevelopfrom
Conversation
|
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
|
This needs a rebase and CI should work |
d8bc197 to
c6c402d
Compare
|
It seems like where ever hh downloads |
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Previously the node API, used by the batcher, wouldn't submit batches if they are empty.
However, if the sequencer lags or has other hiccups, it may build one or more extra L2 blocks in a sequencing window with the margin it has, before adopting the next L1 origin. If that is not submitted on-chain, then the driver does not see that the L1 origin is delayed, and builds a different chain. The sequencer runs this same derivation process, and would even reorg itself.
As temporary fix we can just include those empty batches, and the
epochof those will be synced between sequencer and verifier, even if the block is empty. This should just avoid the reorgs caused by differentepochvalues.While we're still working on the new batch-submitter/derivation code this temporary fix should fix the reorg issue (tm).