Skip to content

Comments

Bedrock - temporary batch-builder reorg fix - don't omit empty batches#2705

Merged
mergify[bot] merged 2 commits intodevelopfrom
fix-empty-batches
Jun 7, 2022
Merged

Bedrock - temporary batch-builder reorg fix - don't omit empty batches#2705
mergify[bot] merged 2 commits intodevelopfrom
fix-empty-batches

Conversation

@protolambda
Copy link
Contributor

Previously the node API, used by the batcher, wouldn't submit batches if they are empty.

However, if the sequencer lags or has other hiccups, it may build one or more extra L2 blocks in a sequencing window with the margin it has, before adopting the next L1 origin. If that is not submitted on-chain, then the driver does not see that the L1 origin is delayed, and builds a different chain. The sequencer runs this same derivation process, and would even reorg itself.

As temporary fix we can just include those empty batches, and the epoch of those will be synced between sequencer and verifier, even if the block is empty. This should just avoid the reorgs caused by different epoch values.

While we're still working on the new batch-submitter/derivation code this temporary fix should fix the reorg issue (tm).

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2022

⚠️ No Changeset found

Latest commit: 3dbb651

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tynes
Copy link
Contributor

tynes commented Jun 7, 2022

This needs a rebase and CI should work

@tynes
Copy link
Contributor

tynes commented Jun 7, 2022

It seems like where ever hh downloads solc from isn't available:

#27 47.18 lerna ERR! yarn run build exited 1 in '@eth-optimism/contracts'
#27 47.18 lerna ERR! yarn run build stdout:
#27 47.18 $ yarn build:contracts && yarn autogen:artifacts && yarn build:typescript
#27 47.18 $ hardhat compile --show-stack-traces
#27 47.18 Downloading compiler 0.5.17
#27 47.18 
#27 47.18 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
#27 47.18 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
#27 47.18 lerna ERR! yarn run build stderr:
#27 47.18 Error HH501: Couldn't download compiler version 0.5.17. Please check your connection.
#27 47.18 HardhatError: HH501: Couldn't download compiler version 0.5.17. Please check your connection.

@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 4a1a364 into develop Jun 7, 2022
@mergify mergify bot deleted the fix-empty-batches branch June 7, 2022 20:46
@mergify mergify bot removed the on-merge-train label Jun 7, 2022
This was referenced Jun 8, 2022
theochap added a commit that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants