Skip to content

specs: Fix inconsistencies within documentation#2658

Merged
mergify[bot] merged 6 commits intodevelopfrom
jg/tob_10
Jun 8, 2022
Merged

specs: Fix inconsistencies within documentation#2658
mergify[bot] merged 6 commits intodevelopfrom
jg/tob_10

Conversation

@trianglesphere
Copy link
Contributor

@trianglesphere trianglesphere commented Jun 2, 2022 •
edited
Loading

Description
Three small commits + one wontfix to fix the four inconsistencies that ToB found in our documentation.

Metadata

  • Fixes ENG-2152

@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: c01765e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot requested review from Inphi and tuxcanfly June 2, 2022 20:22
@trianglesphere trianglesphere requested review from maurelian and protolambda and removed request for Inphi and tuxcanfly June 2, 2022 20:22
@mergify mergify bot requested review from Inphi and tuxcanfly June 2, 2022 20:23
@mergify mergify bot requested review from Inphi and tuxcanfly June 2, 2022 20:24
@mergify mergify bot requested review from Inphi and tuxcanfly June 2, 2022 21:39
smartcontracts
smartcontracts reviewed Jun 2, 2022
View reviewed changes
maurelian
maurelian reviewed Jun 3, 2022
View reviewed changes
@trianglesphere trianglesphere requested a review from maurelian June 3, 2022 20:04
maurelian
maurelian requested changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, though for the sake of the auditors I'd like if we can explain the reason for the one wontfix.

@trianglesphere trianglesphere mentioned this pull request Jun 7, 2022
Closed
protolambda
protolambda reviewed Jun 7, 2022
View reviewed changes
Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor typo-like issue to fix still, see review.

@maurelian maurelian force-pushed the jg/tob_10 branch 2 times, most recently from 21d0a3c to 70e05f0 Compare June 8, 2022 15:46
@maurelian maurelian requested a review from protolambda June 8, 2022 15:46
trianglesphere and others added 6 commits June 8, 2022 14:41
@trianglesphere @maurelian
specs: Update executePayloadV1 to newPayloadV1
eb4d5fe 
Just updating the name in the specs. This has already been changed
in the code.
@trianglesphere @maurelian
specs: Deposits -> Withdrawals spec clarification
2a19972 
Wording was incorrect.
@trianglesphere @maurelian
specs: Remove unnecessary cast
f58f4b8 
The casts from bytes32 -> uint256 -> bytes32 is not needed.
@maurelian
specs: no alias on withdrawals
3e67410
@trianglesphere @maurelian
fix lint
4402771
@maurelian @protolambda
specs: fix parentheses
c01765e 
Co-authored-by: Diederik Loerakker <proto@protolambda.com>
@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit fa0e4de into develop Jun 8, 2022
@mergify mergify bot deleted the jg/tob_10 branch June 8, 2022 18:52
@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jun 8, 2022
This was referenced Jun 8, 2022
Merged
Merged
theochap pushed a commit that referenced this pull request Dec 10, 2025
@gap-editor
chore: fix link to monitoring.mdx (#2658)
50c9f61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mslipper mslipper mslipper approved these changes

@smartcontracts smartcontracts smartcontracts approved these changes

@maurelian maurelian maurelian approved these changes

@Inphi Inphi Awaiting requested review from Inphi

@tuxcanfly tuxcanfly Awaiting requested review from tuxcanfly

@protolambda protolambda Awaiting requested review from protolambda

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@trianglesphere @mslipper @smartcontracts @protolambda @maurelian