merge #1
Merged
merge #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k hours Closes #2099 Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Mingliang Liu <[email protected]>
…doc as support dynamically change Closes #2101 Signed-off-by: Viraj Jasani <[email protected]>
…ate if any region of that table is not open Closes #2047 Signed-off-by: Mingliang Liu <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
Running `ServerKillingChaosMonkey` via `RESTApiClusterManager` for any duration of time slowly leaks region servers. I see failures on the RESTApi side go unreported on the ChaosMonkey side. It seems like `RuntimeException`s are being thrown and lost. `PolicyBasedChaosMonkey` uses a primitive means of thread management anyway. Update to use a thread pool, thread groups, and an uncaughtExceptionHandler. Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
…2071) Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]>
Signed-off-by: Bharath Vissapragada <[email protected]>
…ases (Refactor SlowLog responses)" This reverts commit 16f306b. TestAdminShell and TestThriftHBaseServiceHandler are failing consistently
Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Mingliang Liu <[email protected]>
) Signed-off-by: Wellington Chevreuil <[email protected]>
…tes" Closes #2087 Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
…factor SlowLog responses) (#2109) Closes #2052 Signed-off-by: Wellington Chevreuil <[email protected]>
…n server count Sometimes running chaos monkey, I've found that we lose accounting of region servers. I've taken to a manual process of checking the reported list against a known reference. It occurs to me that ChaosMonkey has a known reference, and it can do this accounting for me. Signed-off-by: Viraj Jasani <[email protected]>
…licies against contained tables Closes #1935 Signed-off-by: Josh Elser <[email protected]>
2.1 is EOM so the 2.1 Documentation link can be removed. The content is still available under https://hbase.apache.org/2.1 Signed-off-by: Jan Hentschel <[email protected]>
…2122) Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]>
Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: stack <[email protected]>
…n based on hbase.rpc.rows.warning.threshold Closes #2127 Signed-off-by: stack <[email protected]>
Co-authored-by: wen_yi <[email protected]> Signed-off-by: Anoop <[email protected]> Signed-off-by: Ramkrishna <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
#2118) Signed-off-by: Josh Elser <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
Closes #2147 Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
…tions on related classes (#2140) Signed-off-by: stack <[email protected]>
…d of polluting the root namespace (#2141) * HBASE-11686 Shell code should create a binding / irb workspace instead of polluting the root namespace - Refactor Shell.export_commands to define commands using ruby lambdas. Additionally, this change stores a reference to shell_inst in scope so that we no longer need to assume the existance of the variable @shell. - Add logic to Shell class for constructing an IRB workspace with its own binding and non-global receiver. This workspace is loaded with all HBase and IRB commands. - Create new method on Shell for evaluating input from an arbitrary IO instance within the created IRB workspace. This is based on work by Hsieh that was previously in bin/hirb.rb. This method is more generic and more testable. This single pattern can be used for both executing files and reading from stdin, therefore reducing complexity. - Move special 'help' and 'tools' command definitions to shell.rb. These commands are tightly linked with an instance of the shell, so it is easiest to have them defined together. - Remove all global includes of HBaseConstants from ruby test files. Before this change, tests were loading these constants into the top level, which could cause tests to pass that should really fail. - Try to reduce the number of places that constants are included. I think it's best to reference each ruby constant's full name, but where that would cause a big diff I instead moved the include to the innermost Module or Class. - Update docs and comments - Remove unneccessary includes - Add shell --top-level-cmds compatibility flag. Since this PR removes all the HBase symbols from the top-level receiver (ie. main Object), it is possible (albeit unlikely) that this will break operator scripts. This flag will export all the commands at the top-level like the shell previously did. * HBASE-11686 Light refactoring with added unit tests - Fixes some constants references by admin test 2 - Install HBase commands as singleton methods on recevier instances so that multiple receivers may exist. - Rename new flag from --top-level-cmds to --top-level-defs to be more semantically accurate. - Create new helper method Shell::Shell#export_all to install @hbase, @shell, constants, and all hbase commands to a target receiver. As a result, the HBaseReceiver became very simple and could be moved to shell.rb. - Add unit tests for Shell::Shell#eval_io and Shell::Shell#export_all - Add @hbase and @shell to hbase-shell IRB workspace - Fix robocop issues within patch * Typo s/is/if/
…end of file from server when SSL enabled (#2123) Signed-off-by: Elliot Miller <[email protected]>
…able name in shell (#2161) - In HBase::Table, the instance variable @converters is used to map column names to converters. This patch fixes how HBase::Table#_get_internal and HBase::Table#_scan_internal generate the column name key used to access @converters. - Refactor parsing of family:qualifier:converter specifications so that the code is more readable and reusable. As part of this change, I added two private methods and marked HBase::Table#set_converter as deprecated for removal in HBase 4.0.0. - Add unit testing for the fixed bug Signed-off-by: stack <[email protected]>
Signed-off-by: Anoop <[email protected]> Signed-off-by: Pankaj Kumar<[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: stack <[email protected]>
… Add deprecation of 'classic' zk-based WAL splitter. (#2156) Also fix three bugs: * We were trying to delete non-empty directory; weren't doing accounting for meta WALs where meta had moved off the server (successfully) * We were deleting split WALs rather than archiving them. * We were not handling corrupt files. Deprecations and removal of tests of old system. Signed-off-by: Anoop Sam John <[email protected]>
Add outline of how the mechanism works generally. Signed-off-by: Anoop Sam John [email protected] Signed-off-by: Viraj Jasani [email protected] Signed-off-by: Jan Hentschel [email protected]
…losed connection (#2162) Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
We observed this delete call to be a bottleneck for table with lots of regions. Patch attempts to parallelize them. Signed-off-by: Andrew Purtell <[email protected]>
Closes #2175 Signed-off-by: Viraj Jasani <[email protected]>
if hbase.rowlock.wait.duration is <=0 then log a message and treat it as a value of 1ms. Signed-off-by: Viraj Jasani <[email protected]>
#2178) - Update all hbase-shell commands to return help text implicitly - Add hbase-shell test to ensure all help methods return unindented text - Set the outermost indentation to zero for the help text of all hbase-shell commands by using the squiggly heredoc added in Ruby 2.3.0. - Document return value of hbck_chore_run and add usage examples to truncate commands - Update docs to reflect current return value of list command Signed-off-by: stack <[email protected]>
…d. (#2168) Signed-off-by: Ramkrishna <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Josh Elser <[email protected]>
…o GPG keys. (#2001) Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Matt Foley <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
* refactor how we use connection and async connection to rely on their access methods * refactor initialization and cleanup of the shared connection * incompatibly change HCTU's Configuration member variable to be final so it can be safely accessed from multiple threads. Closes #2180 Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
Closes #2042 Signed-off-by: Viraj Jasani <[email protected]>
* null check for writer if not initialized yet during syncrunner run * Revert "null check for writer if not initialized yet during syncrunner run" This reverts commit 72932ad. * Writer check while trying to attain safe point Signed-off-by: Anoop Sam John <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Ramkrishna <[email protected]>
…elativePath method (#2167) Signed-off-by: Anoop <[email protected]> Signed-off-by: Ted Yu <[email protected]>
* RegionMover to ignore move failures for split/merged regions with ack mode * Refactor MoveWithAck and MoveWithoutAck as high level classes * UT for RegionMover gracefully handling split/merged regions while loading regions and throwing failure while loading offline regions Closes #2172 Signed-off-by: Sean Busbey <[email protected]> Signed-off-by: Ted Yu <[email protected]>
…Set hbase.regionserver.user.metrics.enabled default to false; i.e. off. (#2132) Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Jan Hentschel <[email protected]>
…er.CleanerChore: Can NOT create CleanerDelegate= ClassNotFoundException) (#2181) Signed-off-by: Anoop Sam John <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Sean Busbey <[email protected]>
Signed-off-by: stack <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: tedyu <[email protected]>
…t to reduce redundancy code Closes #2200 Signed-off-by: Viraj Jasani <[email protected]>
…lit/merge/compact/flush transaction journals Closes #2204 Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Mingliang Liu <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
Co-authored-by: niuyulin <[email protected]> Signed-off-by: stack <[email protected]>
…nPolicy (#2203) Looped through the test 100 times and it passes. Without the patch it fails every ~10 runs or so. Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Michael Stack <[email protected]>
…2198) Allow specifying base WALEntry filter on construction of ReplicationSource. Add means of being able to filter WALs by name. hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java Add constructor that allows passing a predicate for filtering *in* WALs and a list of filters for filtering *out* WALEntries. The latter was hardcoded to filter out system-table WALEntries. The former did not exist but we'll need it if Replication takes in more than just the default Provider. Signed-off-by Anoop Sam John <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
Co-authored-by: niuyulin <[email protected]> SIgned-off-by: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>
Signed-off-by: Elliot Miller <[email protected]> Signed-off-by: stack <[email protected]>
Signed-off-by: Wellington Chevreuil <[email protected]>
Closes #2196 Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Ted Yu <[email protected]>
Signed-off-by: stack <[email protected]>
Closes #2193 Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Sean Busbey <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.