[HBASE-24714] Error message is displayed in the UI of table's compact… #2047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
requested changes
Jul 12, 2020
Contributor
virajjasani
left a comment
virajjasani
left a comment
There was a problem hiding this comment.
Left one comment. Seems we need more thoughts on this.
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
Outdated
Show resolved
Hide resolved
liuml07
reviewed
Jul 17, 2020
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
Outdated
Show resolved
Hide resolved
| byte[] regionName = admin.getRegions(tableName).get(0).getRegionName(); | ||
| admin.unassign(regionName, true); | ||
| TEST_UTIL.waitUntilNoRegionsInTransition(10000); | ||
| try { |
Member
There was a problem hiding this comment.
try {
admin.getCompactionState(tableName);
} catch (IOException e) {
fail("Exception is not excepted.");
}
is the same as
admin.getCompactionState(tableName);
Tests fails in case of exceptions.
…ion state if any region of that table is not open.
sanjeetnishad95
force-pushed
the
webuicompact
branch
from
d8947c6 to
021647b
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
reviewed
Jul 20, 2020
Contributor
virajjasani
left a comment
virajjasani
left a comment
There was a problem hiding this comment.
One null check should make this ready to go. Nice patch.
| for(StackTraceElement element : e.getStackTrace()) { | ||
| %><%= StringEscapeUtils.escapeHtml4(element.toString()) %><% | ||
| if(e.getCause().getCause() instanceof NotServingRegionException) { |
Contributor
There was a problem hiding this comment.
if(e.getCause() != null && e.getCause().getCause() instanceof NotServingRegionException)
…ion state if any region of that table is not open.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
pushed a commit
that referenced
this pull request
Jul 21, 2020
…ate if any region of that table is not open Closes #2047 Signed-off-by: Mingliang Liu <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
virajjasani
pushed a commit
that referenced
this pull request
Jul 21, 2020
…ate if any region of that table is not open Closes #2047 Signed-off-by: Mingliang Liu <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
clarax
pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
…ate if any region of that table is not open Closes apache#2047 Signed-off-by: Mingliang Liu <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion state if any region of that table is not open.