HBASE-24718 : Generic NamedQueue framework for multiple use-cases (Refactor SlowLog responses) #2052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…factor SlowLog responses)
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
reviewed
Jul 13, 2020
Contributor
wchevreuil
left a comment
wchevreuil
left a comment
There was a problem hiding this comment.
Since we are working on refactoring, could we make leg event handler/log service generic enough for further additions of other possible log services in the future?
hbase-server/src/main/java/org/apache/hadoop/hbase/namequeues/LogEventHandler.java
Show resolved
Hide resolved
| // If NamedQueue of specific type is enabled, corresponding Queue will be used to | ||
| // insert and retrieve records. | ||
| // Individual queue sizes should be determined based on their individual configs. | ||
| private final Map<NamedQueuePayload.NamedQueueEvent, Queue> namedQueues = new HashMap<>(); |
Contributor
There was a problem hiding this comment.
For example, the caller should be able to determine which queue implementations (and its related services) should be loaded. That would isolate LogEventHandler from being constantly modified by additional services requiring this type of loggings.
Contributor
Author
There was a problem hiding this comment.
Strategy pattern is good thought but we don't have common payload coming from client so far. Specifically when admin client will talk to RSRpcServer and that will talk to LogEventHandler, they expect specific payload for specific use-case. However, this fits well for strategy pattern and we should have common request payload. Let me try this one. Thanks for the suggestion @wchevreuil .
hbase-server/src/main/java/org/apache/hadoop/hbase/namequeues/SlowLogPersistentService.java
Show resolved
Hide resolved
virajjasani
commented
Jul 13, 2020
Contributor
Author
virajjasani
left a comment
virajjasani
left a comment
There was a problem hiding this comment.
While not all service could use interface e.g persistence will only be used for specific use-cases, but service layer that stores actual queue implementation can have well defined strategy pattern. Let me try this.
hbase-server/src/main/java/org/apache/hadoop/hbase/namequeues/SlowLogPersistentService.java
Show resolved
Hide resolved
| // If NamedQueue of specific type is enabled, corresponding Queue will be used to | ||
| // insert and retrieve records. | ||
| // Individual queue sizes should be determined based on their individual configs. | ||
| private final Map<NamedQueuePayload.NamedQueueEvent, Queue> namedQueues = new HashMap<>(); |
Contributor
Author
There was a problem hiding this comment.
Strategy pattern is good thought but we don't have common payload coming from client so far. Specifically when admin client will talk to RSRpcServer and that will talk to LogEventHandler, they expect specific payload for specific use-case. However, this fits well for strategy pattern and we should have common request payload. Let me try this one. Thanks for the suggestion @wchevreuil .
virajjasani
commented
Jul 13, 2020
Contributor
Author
virajjasani
left a comment
virajjasani
left a comment
There was a problem hiding this comment.
Updated PR with requested changes for Queue service implementation with strategy pattern
hbase-server/src/main/java/org/apache/hadoop/hbase/namequeues/LogEventHandler.java
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
wchevreuil
reviewed
Jul 14, 2020
|
|
||
| LogEventHandler(final Configuration conf) { | ||
| // add all service mappings here | ||
| namedQueueServices |
Contributor
There was a problem hiding this comment.
How about define a String collection property for all implementations of NamedQueueService? So that this handler can load those dynamically, without requiring code changes once new implementations are added.
Contributor
Author
There was a problem hiding this comment.
Your suggestion is to use reflection to find all implementors of NamedQueueService interface? Or some separate string collection? If we have separate immutable string(classname) collection, even that will require changes once we implement new implementor. Or I am missing something?
Contributor
There was a problem hiding this comment.
Use reflection and avoid changing this class with every new implementation added, something similar to what we do for SaslServerAuthenticationProviders
hbase-server/src/main/java/org/apache/hadoop/hbase/namequeues/SlowLogPersistentService.java
Show resolved
Hide resolved
…ng to update LogEventHandler
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
approved these changes
Jul 17, 2020
virajjasani
added a commit
that referenced
this pull request
Jul 17, 2020
…factor SlowLog responses) Closes #2052 Signed-off-by: Wellington Chevreuil <[email protected]>
virajjasani
added a commit
that referenced
this pull request
Jul 21, 2020
…factor SlowLog responses) (#2109) Closes #2052 Signed-off-by: Wellington Chevreuil <[email protected]>
virajjasani
added a commit
that referenced
this pull request
Jul 22, 2020
…factor SlowLog responses) (#2110) Closes #2052 Signed-off-by: Wellington Chevreuil <[email protected]>
clarax
pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
…factor SlowLog responses) Closes apache#2052 Signed-off-by: Wellington Chevreuil <[email protected]>
clarax
pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
…factor SlowLog responses) (apache#2110) Closes apache#2052 Signed-off-by: Wellington Chevreuil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.