HBASE-24794 hbase.rowlock.wait.duration should not be <= 0 #2174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
to clarify, my warning about test log size is only when running the test without the new guardrail. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
reviewed
Jul 30, 2020
Contributor
virajjasani
left a comment
virajjasani
left a comment
There was a problem hiding this comment.
Left one nit, +1 otherwise
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Jul 30, 2020
if hbase.rowlock.wait.duration is <=0 then log a message and treat it as a value of 1ms. Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 840a557)
asfgit
pushed a commit
that referenced
this pull request
Jul 30, 2020
if hbase.rowlock.wait.duration is <=0 then log a message and treat it as a value of 1ms. Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 840a557)
asfgit
pushed a commit
that referenced
this pull request
Jul 30, 2020
if hbase.rowlock.wait.duration is <=0 then log a message and treat it as a value of 1ms. Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 840a557)
|
🎊 +1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Jul 30, 2020
if hbase.rowlock.wait.duration is <=0 then log a message and treat it as a value of 1ms. amended for branches-1 Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 840a557)
asfgit
pushed a commit
that referenced
this pull request
Jul 30, 2020
if hbase.rowlock.wait.duration is <=0 then log a message and treat it as a value of 1ms. amended for branches-1 Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 840a557) (cherry picked from commit 51161b5)
asfgit
pushed a commit
that referenced
this pull request
Jul 30, 2020
if hbase.rowlock.wait.duration is <=0 then log a message and treat it as a value of 1ms. amended for branches-1 amended for branch-1.3 as test-only to verify existing behavior. Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 840a557) (cherry picked from commit 51161b5)
|
🎊 +1 overall
This message was automatically generated. |
clarax
pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
if hbase.rowlock.wait.duration is <=0 then log a message and treat it as a value of 1ms. Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 840a557)
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
if hbase.rowlock.wait.duration is <=0 then log a message and treat it as a value of 1ms. Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 840a557) (cherry picked from commit 7607c7b) Author: Sean Busbey <[email protected]> Reason: Bug Ref: CDPD-15671 Change-Id: I51bf46cd9f0ad61a163a92dca7cd4932a20c55a8 (cherry picked from commit 0503822)
wchevreuil
pushed a commit
to wchevreuil/hbase
that referenced
this pull request
May 24, 2021
if hbase.rowlock.wait.duration is <=0 then log a message and treat it as a value of 1ms. Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 840a557) (cherry picked from commit 7607c7b) Change-Id: I51bf46cd9f0ad61a163a92dca7cd4932a20c55a8
udaynpusa
pushed a commit
to mapr/hbase
that referenced
this pull request
Jan 30, 2024
if hbase.rowlock.wait.duration is <=0 then log a message and treat it as a value of 1ms. amended for branches-1 Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 840a557) (cherry picked from commit 51161b5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with just the new test, things fail after spinning until timeout
warning for those looking to duplicate this, there are about 2.5 million copies of this message
and it takes a bit of room
test passes after this patch is in place, verified presence of warning in test logs. test-only backport to branch-1.3 also passes without the HRegion change.
tested out a branch-2.1 based backport on a cluster and that also worked as expected (logged a warning and then writes to meta were able to succeed)