HBASE-24826 Add some comments for processlist in hbase shell #2207

bsglz · 2020-08-06T09:10:36Z

No description provided.

Apache-HBase · 2020-08-06T09:17:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1 💚	rubocop	0m 3s	There were no new rubocop issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		2m 2s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2207/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2207
Optional Tests	dupname asflicense rubocop
uname	Linux d83cdc59d584 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c39cad2`
Max. process+thread count	47 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2207/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-06T09:33:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 40s	master passed
+1 💚	javadoc	0m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 28s	the patch passed
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	6m 56s	hbase-shell in the patch passed.
		17m 23s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2207/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2207
Optional Tests	javac javadoc unit
uname	Linux fb2a65da092c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c39cad2`
Default Java	1.8.0_232
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2207/1/testReport/
Max. process+thread count	2185 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2207/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-06T09:33:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 11s	master passed
+1 💚	javadoc	0m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 8s	the patch passed
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
-1 ❌	unit	6m 50s	hbase-shell in the patch failed.
		17m 54s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2207/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2207
Optional Tests	javac javadoc unit
uname	Linux 5f27cc6a9cb2 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c39cad2`
Default Java	2020-01-14
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2207/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2207/1/testReport/
Max. process+thread count	2339 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2207/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

bitoffdev · 2020-08-06T16:53:47Z

hbase-shell/src/main/ruby/shell/commands/processlist.rb

-  hbase> processlist 'handler'
-  hbase> processlist 'rpc'
-  hbase> processlist 'operation'
+  hbase> processlist 'general'     //non-RPC Tasks, such as compact, flush etc


Thanks for this @bsglz! Documentation like this is a little inconsistent in format throughout our commands, but I think it would be good to follow the precedent of the RSGroup commands and place these comments on the preceding lines with a ruby-style comment (#) since the shell is ruby.

Ex:

hbase/hbase-shell/src/main/ruby/shell/commands/set_peer_tableCFs.rb

Line 35 in 8003a15

# set table-cfs config is null, then the namespaces config decide which

Will fix later.
Thanks.

Apache-HBase · 2020-08-07T02:12:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1 💚	rubocop	0m 4s	There were no new rubocop issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		2m 0s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2207/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2207
Optional Tests	dupname asflicense rubocop
uname	Linux 44b830b8fe8b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f710d2d`
Max. process+thread count	47 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2207/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-07T02:28:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 20s	master passed
+1 💚	javadoc	0m 18s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 0s	the patch passed
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
-1 ❌	unit	6m 54s	hbase-shell in the patch failed.
		17m 22s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2207/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2207
Optional Tests	javac javadoc unit
uname	Linux a702c5cf7dd4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f710d2d`
Default Java	2020-01-14
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2207/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2207/2/testReport/
Max. process+thread count	2347 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2207/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-07T02:28:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 7s	master passed
+1 💚	javadoc	0m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 22s	the patch passed
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 2s	hbase-shell in the patch passed.
		17m 31s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2207/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2207
Optional Tests	javac javadoc unit
uname	Linux b34e548b5069 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f710d2d`
Default Java	1.8.0_232
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2207/2/testReport/
Max. process+thread count	2184 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2207/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: Elliot Miller <[email protected]> Signed-off-by: stack <[email protected]>

…2207) Signed-off-by: Elliot Miller <[email protected]> Signed-off-by: stack <[email protected]>

HBASE-24826 Add some comments for processlist in hbase shell

ed43153

bitoffdev suggested changes Aug 6, 2020

View reviewed changes

bsglz added 2 commits August 7, 2020 09:59

fix review issue

71c5394

remove blank line

82c3af3

saintstack merged commit 9b49bd6 into apache:master Aug 7, 2020

saintstack pushed a commit that referenced this pull request Aug 7, 2020

HBASE-24826 Add some comments for processlist in hbase shell (#2207)

cb3dd99

Signed-off-by: Elliot Miller <[email protected]> Signed-off-by: stack <[email protected]>

clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020

HBASE-24826 Add some comments for processlist in hbase shell (apache#…

f720428

…2207) Signed-off-by: Elliot Miller <[email protected]> Signed-off-by: stack <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-24826 Add some comments for processlist in hbase shell #2207

HBASE-24826 Add some comments for processlist in hbase shell #2207

Uh oh!

bsglz commented Aug 6, 2020

Uh oh!

Apache-HBase commented Aug 6, 2020

Uh oh!

Apache-HBase commented Aug 6, 2020

Uh oh!

Apache-HBase commented Aug 6, 2020

Uh oh!

bitoffdev Aug 6, 2020

Uh oh!

bsglz Aug 7, 2020

Uh oh!

Apache-HBase commented Aug 7, 2020

Uh oh!

Apache-HBase commented Aug 7, 2020

Uh oh!

Apache-HBase commented Aug 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HBASE-24826 Add some comments for processlist in hbase shell #2207

HBASE-24826 Add some comments for processlist in hbase shell #2207

Uh oh!

Conversation

bsglz commented Aug 6, 2020

Uh oh!

Apache-HBase commented Aug 6, 2020

Uh oh!

Apache-HBase commented Aug 6, 2020

Uh oh!

Apache-HBase commented Aug 6, 2020

Uh oh!

bitoffdev Aug 6, 2020

Choose a reason for hiding this comment

Uh oh!

bsglz Aug 7, 2020

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Aug 7, 2020

Uh oh!

Apache-HBase commented Aug 7, 2020

Uh oh!

Apache-HBase commented Aug 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants